✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6043

DarkIsDude · 2026-01-08T16:02:38Z

Related issues

https://scality.atlassian.net/browse/CLDSRV-813

codecov · 2026-01-08T16:11:00Z

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.34%. Comparing base (f626fcb) to head (3ceb257).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/bucketGet.js	72.72%	6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (73.91%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/metadataSearch.js	`76.38% <100.00%> (+0.33%)`	⬆️
lib/routes/veeam/list.js	`97.50% <ø> (ø)`
lib/api/bucketGet.js	`92.85% <72.72%> (-3.39%)`	⬇️

@@                                     Coverage Diff                                     @@
##           feature/CLDSRV-812/list-objects-v2-optional-permissions    #6043      +/-   ##
===========================================================================================
- Coverage                                                    84.36%   84.34%   -0.02%     
===========================================================================================
  Files                                                          204      204              
  Lines                                                        12935    12957      +22     
===========================================================================================
+ Hits                                                         10912    10928      +16     
- Misses                                                        2023     2029       +6

Flag	Coverage Δ
file-ft-tests	`67.37% <30.43%> (-0.07%)`	⬇️
kmip-ft-tests	`28.08% <0.00%> (-0.05%)`	⬇️
mongo-v0-ft-tests	`68.63% <34.78%> (-0.07%)`	⬇️
mongo-v1-ft-tests	`68.62% <34.78%> (-0.07%)`	⬇️
multiple-backend	`35.33% <26.08%> (-0.03%)`	⬇️
sur-tests	`36.42% <4.34%> (+0.74%)`	⬆️
sur-tests-inflights	`37.43% <4.34%> (-0.07%)`	⬇️
unit	`69.99% <69.56%> (+0.05%)`	⬆️
utapi-v2-tests	`34.35% <26.08%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/api/bucketGet.js

tests/functional/aws-node-sdk/test/object/mpuVersion.js

francoisferrand · 2026-01-11T20:25:20Z

tests/functional/aws-node-sdk/test/object/mpuVersion.js

    for (const version of versions) {
        if (version.value) {
            version.value.uploadId = undefined;
+            version.value.restoreStatus = undefined;


why do we need to clear RestoreStatus from all of these tests?

RestoreStatus is only set by cold storage, so will not be set in most case : so seems best to keep this "as is" and handle the cold-storage tests

The issue is that we call directly metadata.listObject in tests. Regarding arsenal PR, the restoreStatus attribute will be returned as soon as we have an archive field.

And we have a diff. The issue is that the versionBefore do a fakeMetadataArchive that update the object. So the version before contains it. This is not done in the second one (versionAfter) and so we have this diff. Regarding the test, that make sense and our API don't change, here we have this diff just because we don't call our API but internal arsenal function.

francoisferrand · 2026-01-11T20:26:48Z

tests/functional/aws-node-sdk/test/object/putVersion.js

+
+    for (const version of versions) {
+        if (version.value) {
+            version.value.restoreStatus = undefined;


why do we need to clear RestoreStatus in every test?

all APIs should behave the same as before, so you should not need to tweak the tests
(and resetting restoreStatus may be expected -if anywhere- only in tests where you do actually invoke the list object v2 api with optional attributes)

#6043 (comment)

tests/unit/api/bucketGet.js

francoisferrand · 2026-01-11T20:33:36Z

tests/unit/api/bucketGet.js

                assert.strictEqual(err, null);
                assert.strictEqual(result.ListBucketResult.$.xmlns, 'http://s3.amazonaws.com/doc/2006-03-01/');
                done();
            });


would be nice to have some functional tests as well : i.e. tests using the AWS sdk to retrieve the values from a running cloudserver service.

As an extra benefit, it would also provide an exemple of how to use the API.

That's done, thanks for the suggestion. It was a good idea 🙏

tests/unit/api/bucketGet.js

lib/api/bucketGet.js

Issue: CLDSRV-813

…e and switch to a subobject usermetadata Issue: CLDSRV-813

Issue: CLDSRV-813

benzekrimaha · 2026-01-14T17:46:42Z

tests/functional/aws-node-sdk/test/bucket/get.js

+                }
+            });
+
+            it('should return an XML if the header is only RestoreStatus even without permission', async () => {


Suggested change

it('should return an XML if the header is only RestoreStatus even without permission', async () => {

it('should always return an XML when the header is RestoreStatus, async () => {

DarkIsDude self-assigned this Jan 8, 2026

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch 3 times, most recently from 1fde211 to a8eba02 Compare January 9, 2026 11:13

DarkIsDude requested review from a team, benzekrimaha and maeldonn January 9, 2026 11:46

francoisferrand reviewed Jan 11, 2026

View reviewed changes

lib/api/bucketGet.js Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/mpuVersion.js Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

tests/unit/api/bucketGet.js Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

DarkIsDude commented Jan 12, 2026

View reviewed changes

tests/unit/api/bucketGet.js Show resolved Hide resolved

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch 3 times, most recently from 3711fb9 to 037e011 Compare January 13, 2026 15:03

DarkIsDude requested a review from francoisferrand January 13, 2026 15:39

benzekrimaha reviewed Jan 13, 2026

View reviewed changes

lib/api/bucketGet.js Show resolved Hide resolved

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch from 037e011 to 9ba243d Compare January 14, 2026 13:39

DarkIsDude added 8 commits January 14, 2026 15:38

✨ update the XML response to support Optional attributes

0dec10d

Issue: CLDSRV-813

✅ add new tests for the new response logic

9a9fc30

Issue: CLDSRV-813

✨ update Veeam route to pass the new params

c7288f9

Issue: CLDSRV-813

✨ update metadataSearch to pass the right arguments

a8b6808

Issue: CLDSRV-813

✨ process attributes as lower case

4aa9ea0

Issue: CLDSRV-813

♻️ parse optional attributes instead of all key to improve performanc…

e1ef26f

…e and switch to a subobject usermetadata Issue: CLDSRV-813

✅ create a new functional tests

83812cd

Issue: CLDSRV-813

✅ add new functional tests to cover more use case

16dbb8b

Issue: CLDSRV-813

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch from b8457d5 to 0d9a18a Compare January 14, 2026 14:38

✅ run test only if vault is available

3ceb257

Issue: CLDSRV-813

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch from 0d9a18a to 3ceb257 Compare January 14, 2026 14:41

DarkIsDude requested a review from benzekrimaha January 14, 2026 14:57

maeldonn removed their request for review January 14, 2026 17:00

benzekrimaha reviewed Jan 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6043

✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6043

DarkIsDude commented Jan 8, 2026

Uh oh!

codecov bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

francoisferrand Jan 11, 2026 •

edited

Loading

Uh oh!

DarkIsDude Jan 13, 2026

Uh oh!

francoisferrand Jan 11, 2026 •

edited

Loading

Uh oh!

DarkIsDude Jan 13, 2026

Uh oh!

Uh oh!

francoisferrand Jan 11, 2026

Uh oh!

DarkIsDude Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

benzekrimaha Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	it('should return an XML if the header is only RestoreStatus even without permission', async () => {
	it('should always return an XML when the header is RestoreStatus, async () => {

✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6043

Are you sure you want to change the base?

✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6043

Conversation

DarkIsDude commented Jan 8, 2026

Related issues

Uh oh!

codecov bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

francoisferrand Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francoisferrand Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

benzekrimaha Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 8, 2026 •

edited

Loading

francoisferrand Jan 11, 2026 •

edited

Loading

francoisferrand Jan 11, 2026 •

edited

Loading