LOGC-16: Fix E2E test chronological order verification

Fix the chronological order invariant in E2E tests.
The tests were incorrectly verifying order across all log objects,
but the actual invariant is that logs within each individual object
are chronologically ordered.

Author: dvasilas

test/e2e/helpers_test.go

@@ -374,7 +374,9 @@ func fetchAllLogsInBucketSince(ctx *E2ETestContext, since time.Time) ([]*ParsedL
 	return fetchLogsFromPrefix(ctx.S3Client, ctx.DestinationBucket, "", since)
 }
 
-// fetchLogsFromPrefix fetches and parses all log records from a specific prefix since a given time
+// fetchLogsFromPrefix fetches and parses all log records from a specific prefix since a given time.
+// Verifies that records within each log object are in chronological order.
+// Returns all records combined across objects (no ordering guarantee across objects).
 func fetchLogsFromPrefix(client *s3.Client, bucket, prefix string, since time.Time) ([]*ParsedLogRecord, error) {
 	objectKeys, err := findLogObjectsSince(client, bucket, prefix, since)
 	if err != nil {
@@ -389,6 +391,15 @@ func fetchLogsFromPrefix(client *s3.Client, bucket, prefix string, since time.Ti
 		}
 
 		records := parseLogContent(content)
+
+		// Verify chronological order within this object
+		for i := 1; i < len(records); i++ {
+			if records[i].Time.Before(records[i-1].Time) {
+				return nil, fmt.Errorf("object %s: logs not in chronological order: record %d (%v) is before record %d (%v)",
+					key, i, records[i].Time, i-1, records[i-1].Time)
+			}
+		}
+
 		allRecords = append(allRecords, records...)
 	}
 
@@ -420,7 +431,7 @@ func waitForLogCount(ctx *E2ETestContext, expectedCount int) []*ParsedLogRecord
 	return waitForLogCountWithPrefix(ctx, ctx.LogPrefix, expectedCount)
 }
 
-// VerifyLogs waits for logs, verifies they match expected values, and checks chronological order.
+// VerifyLogs waits for logs and verifies they match expected values.
 // Returns the logs for additional assertions if needed.
 func (ctx *E2ETestContext) VerifyLogs(expected ...ExpectedLogBuilder) []*ParsedLogRecord {
 	GinkgoHelper()
@@ -431,8 +442,6 @@ func (ctx *E2ETestContext) VerifyLogs(expected ...ExpectedLogBuilder) []*ParsedL
 		verifyLogRecord(logs[i], exp)
 	}
 
-	verifyChronologicalOrder(logs)
-
 	return logs
 }
 
@@ -513,18 +522,6 @@ func verifyLogRecord(actual *ParsedLogRecord, expected ExpectedLogBuilder) {
 	}
 }
 
-// verifyChronologicalOrder verifies logs are in chronological order
-func verifyChronologicalOrder(records []*ParsedLogRecord) {
-	GinkgoHelper()
-
-	for i := 1; i < len(records); i++ {
-		Expect(records[i].Time.After(records[i-1].Time) ||
-			records[i].Time.Equal(records[i-1].Time)).To(BeTrue(),
-			"Logs should be in chronological order: record %d (%v) should be after or equal to record %d (%v)",
-			i, records[i].Time, i-1, records[i-1].Time)
-	}
-}
-
 // verifyLogKeys verifies that logs contain exactly the expected keys with no duplicates.
 // It filters logs by bucket and keyPrefix, then checks:
 // - Each matching log has the expected operation

test/e2e/log_processing_test.go

@@ -42,7 +42,6 @@ var _ = Describe("Log processing", func() {
 		}
 
 		verifyLogKeys(logs, testCtx.SourceBucket, "batch-object-", expectedKeys, opPutObject)
-		verifyChronologicalOrder(logs)
 	})
 
 	It("triggers processing by time threshold", func(ctx context.Context) {
@@ -87,7 +86,6 @@ var _ = Describe("Log processing", func() {
 		Expect(err).NotTo(HaveOccurred())
 
 		verifyLogKeys(allLogs, testCtx.SourceBucket, "cycle", expectedKeys, opPutObject)
-		verifyChronologicalOrder(allLogs)
 	})
 
 	It("processes multiple buckets", func(ctx context.Context) {
@@ -208,7 +206,6 @@ var _ = Describe("Log processing", func() {
 		Expect(seenPairs).To(HaveLen(totalExpected),
 			"Expected %d unique bucket/key pairs, got %d", totalExpected, len(seenPairs))
 
-		verifyChronologicalOrder(logs)
 	})
 
 	It("delivers logs to new prefix after logging reconfiguration", func(ctx context.Context) {