Potential fix for code scanning alert no. 521: Insecure randomness

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Author: tcarmet

tests/utils/S3Setup.js

@@ -3,6 +3,7 @@ const AWS = require('aws-sdk');
 const { promisify } = require('util');
 const { Logger } = require('werelogs');
 const admincredentials = require('vaultclient/tests/utils/admincredentials.json');
+const crypto = require('crypto');
 
 const log = new Logger('S3Setup');
 
@@ -18,7 +19,8 @@ const region = 'us-east-1';
 async function createTestAccount(vaultClient) {
     const iamEndpoint = new AWS.Endpoint(`http://${iamHost}:${iamPort}`);
     const s3Endpoint = new AWS.Endpoint(`http://${s3Host}:${s3Port}`);
-    const accountName = `test-account-${Math.random().toString(36).substring(2, 8)}`;
+    const randomSuffix = crypto.randomBytes(4).toString('hex').substring(0, 6);
+    const accountName = `test-account-${randomSuffix}`;
     const accountEmail = `${accountName}@example.com`;
     const bucketName = accountName;
     const iamUser = `${accountName}-user`;