Skip to content

Commit 01d45db

Browse files
committed
Pass Vertex AI project ID and region as secrets instead of hardcoding
1 parent 1d37796 commit 01d45db

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/workflows/claude-code-review.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ on:
99
GCP_SERVICE_ACCOUNT:
1010
required: true
1111
description: GCP Service Account for Vertex AI
12+
ANTHROPIC_VERTEX_PROJECT_ID:
13+
required: true
14+
description: GCP project ID for Vertex AI
15+
CLOUD_ML_REGION:
16+
required: true
17+
description: GCP region for Vertex AI
1218

1319
jobs:
1420
claude-review:
@@ -41,5 +47,5 @@ jobs:
4147
--allowedTools "Bash(git diff *)" "Bash(git log *)" "Bash(git show *)" "Bash(gh repo view *)" "Bash(gh pr view *)" "Bash(gh pr diff *)" "Bash(gh pr comment *)" "Bash(gh api *)"
4248
--model "claude-opus-4-6"
4349
env:
44-
ANTHROPIC_VERTEX_PROJECT_ID: "claudecode-487808"
45-
CLOUD_ML_REGION: "us-east5"
50+
ANTHROPIC_VERTEX_PROJECT_ID: ${{ secrets.ANTHROPIC_VERTEX_PROJECT_ID }}
51+
CLOUD_ML_REGION: ${{ secrets.CLOUD_ML_REGION }}

.github/workflows/review.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,5 @@ jobs:
1010
secrets:
1111
GCP_WORKLOAD_IDENTITY_PROVIDER: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
1212
GCP_SERVICE_ACCOUNT: ${{ secrets.GCP_SERVICE_ACCOUNT }}
13+
ANTHROPIC_VERTEX_PROJECT_ID: ${{ secrets.ANTHROPIC_VERTEX_PROJECT_ID }}
14+
CLOUD_ML_REGION: ${{ secrets.CLOUD_ML_REGION }}

0 commit comments

Comments
 (0)