Merge pull request ClickHouse#73179 from Avogar/propogate-settings-to-native-tcp-handler

Propagate format settings to NativeWriter in TCPHandler

Author: Avogar

src/Server/TCPHandler.cpp

@@ -15,6 +15,7 @@
 #include <Core/Settings.h>
 #include <Formats/NativeReader.h>
 #include <Formats/NativeWriter.h>
+#include <Formats/FormatFactory.h>
 #include <IO/LimitReadBuffer.h>
 #include <IO/Progress.h>
 #include <IO/ReadBufferFromPocoSocket.h>
@@ -2350,7 +2351,7 @@ void TCPHandler::initBlockOutput(QueryState & state, const Block & block)
             *state.maybe_compressed_out,
             client_tcp_protocol_version,
             block.cloneEmpty(),
-            std::nullopt,
+            getFormatSettings(state.query_context),
             !query_settings[Setting::low_cardinality_allow_in_native_format]);
     }
 }

tests/queries/0_stateless/01825_new_type_json_12.sh

@@ -47,7 +47,7 @@ $CLICKHOUSE_CLIENT -q "SELECT DISTINCT arrayJoin(JSONAllPathsWithTypes(obj)) as
 $CLICKHOUSE_CLIENT -q "SELECT DISTINCT arrayJoin(JSONAllPathsWithTypes(arrayJoin(obj.key_0[]))) as path FROM t_json_12 order by path;"
 $CLICKHOUSE_CLIENT -q "SELECT DISTINCT arrayJoin(JSONAllPathsWithTypes(arrayJoin(arrayJoin(obj.key_0[].key_1[])))) as path FROM t_json_12 order by path;"
 $CLICKHOUSE_CLIENT -q "SELECT DISTINCT arrayJoin(JSONAllPathsWithTypes(arrayJoin(arrayJoin(arrayJoin(obj.key_0[].key_1[].key_3[]))))) as path FROM t_json_12 order by path;"
-$CLICKHOUSE_CLIENT -q "SELECT obj FROM t_json_12 ORDER BY obj.id FORMAT JSONEachRow" --output_format_json_named_tuples_as_objects 1 --allow_suspicious_types_in_order_by 1
+$CLICKHOUSE_CLIENT -q "SELECT obj FROM t_json_12 ORDER BY obj.id FORMAT JSONEachRow" --output_format_json_named_tuples_as_objects 1 --allow_suspicious_types_in_order_by 1 --output_format_native_write_json_as_string=0
 $CLICKHOUSE_CLIENT -q "SELECT obj.key_0[].key_1[].key_3[].key_4, obj.key_0[].key_1[].key_3[].key_5, \
     obj.key_0[].key_1[].key_3[].key_6, obj.key_0[].key_1[].key_3[].key_7 FROM t_json_12 ORDER BY obj.id" --allow_suspicious_types_in_order_by 1
 

tests/queries/0_stateless/01825_new_type_json_in_array.sql

@@ -4,6 +4,7 @@ SET allow_experimental_json_type = 1;
 SET allow_experimental_analyzer = 1;
 SET allow_suspicious_types_in_order_by = 1;
 SET allow_suspicious_types_in_group_by = 1;
+SET output_format_native_write_json_as_string = 0;
 
 DROP TABLE IF EXISTS t_json_array;
 

tests/queries/0_stateless/03282_json_equal_comparison.sql

@@ -1,4 +1,5 @@
 set enable_json_type=1;
+set output_format_native_write_json_as_string=0;
 create table test (json1 JSON(max_dynamic_paths=2, a UInt32), json2 JSON(max_dynamic_paths=2, a UInt32)) engine=Memory;
 insert into test format JSONEachRow
 {"json1" : {}, "json2" : {}}