Skip to content

Commit c509c2d

Browse files
committed
Review correction: customBrandTitle as img.alt and fallback to 'Brand Logo'
1 parent c01beab commit c509c2d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/components/LoginForm/LoginForm.react.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@ import { verticalCenter } from 'stylesheets/base.scss';
1515
export default class LoginForm extends React.Component {
1616
render() {
1717
const customBrandIcon = window.CUSTOM_BRAND_ICON;
18+
const customBrandTitle = window.CUSTOM_BRAND_TITLE;
1819
return (
1920
<div className={styles.login} style={{ marginTop: this.props.marginTop || '-220px' }}>
2021
{!customBrandIcon && <Icon width={80} height={80} name='infinity' fill='#093A59' />}
21-
{customBrandIcon && <img src={'appicons/' + customBrandIcon} width={80} height={80} alt="Custom BRAND icon"/>}
22+
{customBrandIcon && <img src={'appicons/' + customBrandIcon} width={80} height={80} alt={customBrandTitle || 'Brand Logo'} />}
2223
<form method='post' ref='form' action={this.props.endpoint} className={styles.form}>
2324
<CSRFInput />
2425
<div className={styles.header}>{this.props.header}</div>

src/components/Sidebar/SidebarHeader.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default class SidebarHeader extends React.Component {
3030
<div className={styles.header}>
3131
<Link className={styles.logo} to={{ pathname: '/apps' }}>
3232
{!customBrandIcon && <Icon width={28} height={28} name='infinity' fill={'#ffffff'} />}
33-
{customBrandIcon && <img src={'appicons/' + customBrandIcon} width={28} height={28} alt="Custom BRAND icon"/>}
33+
{customBrandIcon && <img src={'appicons/' + customBrandIcon} width={28} height={28} alt={customBrandTitle || 'Brand Logo'} />}
3434
</Link>
3535
<Link to='/apps'>
3636
<div className={styles.version}>

0 commit comments

Comments
 (0)