libraries that define methods as `inline` appear to get linted by Scapegoat

[dontgitit]

sample build.sbt:

lazy val literalThing = (project in file("literalThing")).settings(
  libraryDependencies ++= Seq(
    "com.comcast" %% "ip4s-core" % "3.6.0"
  )
)

literalThing/src/main/scala/Main.scala:

import com.comcast.ip4s.*

object Main {
  def main(args: Array[String]): Unit = {
    println(port"8080")
  }
}

produces the following when running literalThing/scapegoat:

[project directory]\shared\src\main\scala-3\Literals.scala: [scapegoat] [OptionGet] Use of Option.get
[error]   Using Option.get defeats the purpose of using Option in the first place. Use the following instead: Option.getOrElse, Option.fold, pattern matching or don't take the value out of the container and map over it to transform it.
[error]
[error] [scapegoat] Analysis complete: 1 errors 0 warns 0 infos

I'm guessing what's happening is that since the port interpolator is defined as inline, Scapegoat reports on it even though it's not actually part of the project's sources.

[dontgitit]

P.S. trying to suppress these via @SuppressWarnings(Array("all")) on either/both object Main nor def main doesn't actually seem to work; is this expected to stop the error from showing up?

P.P.S. I added Scapegoat / scalacOptions += "-P:scapegoat:overrideLevels:OptionGet=Warning" which changed the errors to warnings, but SuppressWarnings still didn't work

[dontgitit]

Also, attempting to ignore the file doesn't seem to work either; I tried

  scapegoatIgnoredFiles := Seq(
    ".*Main.*",
    ".*Literals.*"
  )

i'm using addSbtPlugin("com.sksamuel.scapegoat" %% "sbt-scapegoat" % "1.2.11") in plugins.sbt

also tried Scapegoat / scalacOptions += "-P:scapegoat:ignoredFiles:.*Main.*:.*Literal.*",

[saeltz]

Thanks for reporting!

trying to suppress these via @SuppressWarnings(Array("all")) on either/both object Main nor def main doesn't actually seem to work; is this expected to stop the error from showing up?

Yes, suppressing the warning is expected and doesn't seem to work.

I think we need multiple things:

1. A test for our Scala 3 implementation for @SuppressWarnings.
2. A test for our Scala 3 implementation for ignored files.
3. A test for our Scala 3 implementation for inlined warnings.
4. Potential fixes for the above.

Would you be willing to contribute (parts of) this yourself?

[dontgitit]

Unfortunately, I don't currently have the bandwidth to contribute.