MDL-59911 fileconverter_unoconv: Fix: test PDF fails after upgrade

Leon Stringer · Leon Stringer · commit c4e1a1518ca3 · 2019-07-16T17:25:23.000+01:00
When generating the PDF of unoconv_test.docx this file's previous conversions
are removed from mdl_file_conversion.  But these may also be removed by
\core_files\task\conversion_cleanup_task in which case an error occurs as
delete() is invoked with a NULL id.  Added check for non-NULL id prior to
invoking delete().
diff --git a/files/converter/unoconv/classes/converter.php b/files/converter/unoconv/classes/converter.php
@@ -194,7 +194,9 @@ public function serve_test_document() {
 
         $conversions = conversion::get_conversions_for_file($testdocx, $format);
         foreach ($conversions as $conversion) {
-            $conversion->delete();
+            if ($conversion->get('id')) {
+                $conversion->delete();
+            }
         }
 
         $conversion = new conversion(0, (object) [

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,9 @@ public function serve_test_document() {`
`194`	`194`
`195`	`195`	`$conversions = conversion::get_conversions_for_file($testdocx, $format);`
`196`	`196`	`foreach ($conversions as $conversion) {`
`197`		`- $conversion->delete();`
	`197`	`+ if ($conversion->get('id')) {`
	`198`	`+ $conversion->delete();`
	`199`	`+ }`
`198`	`200`	`}`
`199`	`201`
`200`	`202`	`$conversion = new conversion(0, (object) [`