Skip to content

Commit 8c4f65e

Browse files
committed
Merge branch 'master' of https://github.com/sccn/BCILAB
2 parents 4b05979 + 3b6f936 commit 8c4f65e

File tree

13 files changed

+1018
-1013
lines changed

13 files changed

+1018
-1013
lines changed

RELEASE NOTES.TXT

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,16 @@ The latest versions of the toolbox can be found at github.com/sccn/BCILAB, and r
7777
code.google.com/p/labstreaminglayer. Besides this, the toolbox continues to natively support BioSemi and BrainProducts hardware, as well as a few common
7878
protocols (TCP, OSC, etc.).
7979

80+
81+
=== Known Issues in Beta Version ===
82+
- utl_kernelize has a bug that renders it non-working (affects ml_trainsvm and ml_trainrvm)
83+
- flt_fir has no minimum-phase implementation for high-pass filters yet, which means that it will incur possibly
84+
intolerable delay (workaround: use flt_iir, or, if working with epochs, flt_spectrum)
85+
- flt_standardize with the sphere setting turned on is not robust to signals that are (almost) rank-deficient
86+
- flt_iir flips the signal sign under some settings (though consistently) and causes rather high CPU load during
87+
online processing
88+
89+
8090
=== Credits ===
8191

8292
If you are using the toolbox for a publication, please consider citing any of the following references:
@@ -299,7 +309,3 @@ Minor Fixes:
299309
- flt_eog: fixed bug which disabled regression when removing EOG channels
300310
- utl_check_dataset: fixed a warning message
301311

302-
Known Issues
303-
- utl_kernelize has a bug that renders it non-working (affects ml_trainsvm and ml_trainrvm)
304-
305-

code/filters/in_development/flt_sourceLocalize.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@
284284
newRoiVertices{k} = A(sort(idx));
285285
end
286286

287-
if appendROI
287+
if ~appendROI
288288
% remove all merged ROIs ...
289289
mergedROI = unique(cell2mat(roiIdxInAtlas));
290290
state.roiVerticesReduced(mergedROI) = [];

code/online_analysis/onl_peek.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,4 @@
8080
% update meta-data
8181
[chunk.nbchan,chunk.pnts,chunk.trials] = size(chunk.data);
8282
chunk.chanlocs = chunk.chanlocs(channels_to_get);
83-
chunk.xmax = chunk.xmin + (chunk.pnts-1)/buf.srate;
83+
chunk.xmax = chunk.xmin + (chunk.pnts-1)/chunk.srate;

dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11/eeg_load_xdf.m renamed to dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11b/eeg_load_xdf.m

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,17 @@
8080
chanlocs(c).labels = chn.label; end
8181
if isfield(chn,'type')
8282
chanlocs(c).type = chn.type; end
83-
if isfield(chn,'location')
84-
try
85-
chanlocs(c).X = str2num(chn.location.X)/1000;
86-
chanlocs(c).Y = str2num(chn.location.Y)/1000;
87-
chanlocs(c).Z = str2num(chn.location.Z)/1000;
88-
[chanlocs(c).sph_theta,chanlocs(c).sph_phi,chanlocs(c).sph_radius] = cart2sph(chanlocs(c).X,chanlocs(c).Y,chanlocs(c).Z);
89-
[chanlocs(c).theta,chanlocs(c).radius] = cart2pol(chanlocs(c).X,chanlocs(c).Y);
90-
chanlocs(c).urchan = c;
91-
chanlocs(c).ref = '';
92-
catch
93-
end
83+
try
84+
chanlocs(c).X = str2num(chn.location.X)/1000;
85+
chanlocs(c).Y = str2num(chn.location.Y)/1000;
86+
chanlocs(c).Z = str2num(chn.location.Z)/1000;
87+
[chanlocs(c).sph_theta,chanlocs(c).sph_phi,chanlocs(c).sph_radius] = cart2sph(chanlocs(c).X,chanlocs(c).Y,chanlocs(c).Z);
88+
[chanlocs(c).theta,chanlocs(c).radius] = cart2pol(chanlocs(c).X,chanlocs(c).Y);
89+
catch
90+
[chanlocs(c).X,chanlocs(c).Y,chanlocs(c).Z,chanlocs(c).sph_theta,chanlocs(c).sph_phi,chanlocs(c).sph_radius,chanlocs(c).theta,chanlocs(c).radius] = deal([]);
9491
end
92+
chanlocs(c).urchan = c;
93+
chanlocs(c).ref = '';
9594
end
9695
raw.chaninfo.nosedir = '+Y';
9796
catch e

dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11/eegplugin_xdfimport.m renamed to dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11b/eegplugin_xdfimport.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
function vers = eegplugin_xdfimport(fig, trystrs, catchstrs)
4747

48-
vers = 'xdfimport1.11';
48+
vers = 'xdfimport1.11b';
4949

5050
if nargin < 3
5151
error('eegplugin_xdfimport requires 3 arguments');

dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11/load_xdf.m renamed to dependencies/eeglab_10_0_1_0x/plugins/xdfimport1.11b/load_xdf.m

Lines changed: 799 additions & 799 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)