Features: switch FeatureExtractor inheritance logic with preprocessor functions #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Testing is failing and looks like the time increase by two. Can you please provide some benchmark comparison? And btw, there is some change in going in braindecode to have more flexibility in the data format. |
Collaborator
|
the increase time is not related with the change :) but some small benchmark is necessary |
Collaborator
Author
|
I added a small benchmark and a very basic test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, meant to simplify both the implementation of new features (e.g., by the user), as well as building the feature extraction tree.
@bruAristimunha:
Please make sure this PR does not interfere with the EEG challenge in any way before you approve it (I waited for the competition to be over).
Also, please verify the following changes:
pyarrowto the deps (required for saving/loading dataframes to parquet files).