wrap pugixml > lslobj > lsl internal dependencies with $<BUILD_INTERFACE:...> because pugixml and lslobj are not needed in the export set

Author: cboulay

cmake/Installation.cmake

@@ -41,10 +41,9 @@ write_basic_package_version_file(
 )
 
 # Define installation targets
+# Note: We only export the final 'lsl' library, not intermediate targets like lslobj.
+# Consumers should link to LSL::lsl, not internal object libraries.
 set(LSLTargets lsl)
-if(LSL_BUILD_STATIC)
-    list(APPEND LSLTargets lslobj lslboost)
-endif()
 
 # Install the targets and store configuration information.
 install(TARGETS ${LSLTargets}

cmake/TargetLib.cmake

@@ -28,7 +28,9 @@ endif()
 # Link dependencies. The only dependency is lslobj, which contains the bulk of the library code and linkages.
 # Note: We link PRIVATE because lslobj exposes extra symbols that are not part of the public API
 #  but are used by the internal tests.
-target_link_libraries(lsl PRIVATE lslobj)
+# Note: We use BUILD_INTERFACE to avoid requiring lslobj in the export set - the object library's
+#  objects are linked directly into lsl, so consumers don't need lslobj.
+target_link_libraries(lsl PRIVATE $<BUILD_INTERFACE:lslobj>)
 
 # Set the include directories for the lsl target.
 # Note: We had to link lslobj as a PRIVATE dependency, therefore we must manually expose the include directories

cmake/TargetObjLib.cmake

@@ -80,7 +80,9 @@ if(NOT LSL_OPTIMIZATIONS)
 endif()
 
 # - pugixml (fetched via FetchContent, linked statically and privately)
-target_link_libraries(lslobj PRIVATE pugixml::pugixml)
+# Use BUILD_INTERFACE to avoid requiring pugixml in the export set - the static
+# library objects are linked into lsl directly, so consumers don't need pugixml.
+target_link_libraries(lslobj PRIVATE $<BUILD_INTERFACE:pugixml::pugixml>)
 # Hide pugixml symbols from the shared library on Linux
 if(UNIX AND NOT APPLE)
     target_link_options(lslobj PRIVATE "LINKER:--exclude-libs,libpugixml.a")