Skip to content

Commit 69472cd

Browse files
committed
Hopefully zipping preserves symlinks before archive upload/download.
1 parent 84d3a9a commit 69472cd

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed

.github/workflows/apple.yml

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,17 @@ jobs:
109109
codesign -vvv --verify --deep --strict install/Frameworks/lsl.framework
110110
fi
111111
112-
- name: upload install dir
112+
- name: Zip LSL Framework
113+
run: |
114+
cd install/Frameworks
115+
zip -r lsl.framework.zip lsl.framework
116+
cd ../..
117+
118+
- name: Upload LSL Framework Zip
113119
uses: actions/upload-artifact@v4
114120
with:
115121
name: build-${{ matrix.config.name }}
116-
path: install
122+
path: install/Frameworks/lsl.framework.zip
117123

118124
# run internal tests
119125
- name: unit tests
@@ -146,6 +152,14 @@ jobs:
146152
name: build-iOS
147153
path: build-iOS
148154

155+
- name: Unzip macOS Framework
156+
run: |
157+
unzip build-macOS-latest/lsl.framework.zip -d build-macOS-latest/Frameworks
158+
159+
- name: Unzip iOS Framework
160+
run: |
161+
unzip build-iOS/lsl.framework.zip -d build-iOS/Frameworks
162+
149163
- name: Install certificates and provisioning profiles
150164
uses: ./.github/actions/install-apple-certs
151165
with:
@@ -177,6 +191,11 @@ jobs:
177191
--wait --verbose
178192
# Staple the notarization ticket to the package
179193
xcrun stapler staple package/liblsl-${LSL_VERSION}-Darwin-universal.pkg
194+
195+
# If notarization fails, you can get the history of notarization requests:
196+
# xcrun notarytool history --apple-id "$APPLE_NOTARIZE_USERNAME" --password "$APPLE_NOTARIZE_PASSWORD" --team-id "$APPLE_DEVELOPMENT_TEAM"
197+
# Then you can check the status of a specific request:
198+
# xcrun notarytool log <request-id> --apple-id "$APPLE_NOTARIZE_USERNAME" --password "$APPLE_NOTARIZE_PASSWORD" --team-id "$APPLE_DEVELOPMENT_TEAM"
180199
181200
- name: Create, Sign, and Notarize XCFramework
182201
env:
@@ -186,7 +205,7 @@ jobs:
186205
run: |
187206
xcodebuild -create-xcframework \
188207
-framework build-macOS-latest/Frameworks/lsl.framework \
189-
-framework build-iOS/install/Frameworks/lsl.framework \
208+
-framework build-iOS/Frameworks/lsl.framework \
190209
-output lsl.xcframework
191210
192211
codesign -vvv --force --deep --sign "$APPLE_CODE_SIGN_IDENTITY_APP" lsl.xcframework

0 commit comments

Comments
 (0)