Change default log.level config when LSL_DEBUGLOG is ON. Change LSL_DEBUGLOG default when CMAKE_BUILD_TYPE is Debug.

Author: cboulay

cmake/ProjectOptions.cmake

@@ -1,7 +1,9 @@
 include(CMakeDependentOption)
 
 # Project build options
-option(LSL_DEBUGLOG "Enable (lots of) additional debug messages" OFF)
+# Default LSL_DEBUGLOG to ON for Debug builds (single-config generators only)
+string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" "Debug" _LSL_DEBUGLOG_DEFAULT)
+option(LSL_DEBUGLOG "Enable (lots of) additional debug messages" ${_LSL_DEBUGLOG_DEFAULT})
 option(LSL_UNIXFOLDERS "Use the unix folder layout for install targets" ON)
 option(LSL_BUILD_STATIC "Build LSL as a static library." OFF)
 option(LSL_FRAMEWORK "Build LSL as an Apple Framework (Mac only)" ON)

src/api_config.cpp

@@ -94,7 +94,12 @@ void api_config::load_from_file(const std::string &filename) {
 		}
 
 		// read the [log] settings
-		int log_level = pt.get("log.level", (int)loguru::Verbosity_INFO);
+#if LOGURU_DEBUG_LOGGING
+		// When built with LSL_DEBUGLOG=ON, default to verbose logging
+		int log_level = pt.get("log.level", 1);
+#else
+		int log_level = pt.get("log.level", static_cast<int>(loguru::Verbosity_INFO));
+#endif
 		if (log_level < -3 || log_level > 9)
 			throw std::runtime_error("Invalid log.level (valid range: -3 to 9");