GHA Apple - Fix artifact management

Author: cboulay

.github/workflows/apple.yml

@@ -127,12 +127,10 @@ jobs:
           APPLE_NOTARIZE_USERNAME: ${{ secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }}
           APPLE_NOTARIZE_PASSWORD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
       run: |
-          set -x
           # Get the version number from the framework's Info.plist
-          VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" install/Frameworks/lsl.framework/Versions/A/Resources/Info.plist)
-          echo "LSL_VERSION=$VERSION" >> $GITHUB_ENV
-          echo $VERSION
-          echo $LSL_VERSION
+          LSL_VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" install/Frameworks/lsl.framework/Versions/A/Resources/Info.plist)
+          echo "LSL_VERSION=$LSL_VERSION" >> $GITHUB_ENV
+          echo "Debug: LSL_VERSION=$LSL_VERSION"
 
           mkdir -p package
           productbuild --sign "$APPLE_CODE_SIGN_IDENTITY_INST" \
@@ -154,13 +152,27 @@ jobs:
         name: dumps-${{ matrix.config.name }}
         path: dumps
 
-    - name: upload install dir
+    - name: Zip LSL Framework
+      run: |
+        cd install/Frameworks
+        zip -r lsl.framework.zip lsl.framework
+        cd ../..
+
+    - name: Upload macOS Package and Framework
+      if: matrix.config.name == 'macOS-latest'
       uses: actions/upload-artifact@v4
       with:
-        name: build-${{ matrix.config.name }}
+        name: build-macOS-latest
         path: |
-          install
           package/*.pkg
+          install/Frameworks/lsl.framework.zip
+
+    - name: Upload iOS Framework
+      if: matrix.config.name == 'iOS'
+      uses: actions/upload-artifact@v4
+      with:
+        name: build-iOS
+        path: install/Frameworks/lsl.framework.zip
 
   package_and_deploy:
     name: Package and Deploy
@@ -177,6 +189,10 @@ jobs:
           name: build-iOS
           path: build-iOS
 
+      - name: Unzip macOS Framework
+        run: |
+          unzip build-macOS-latest/lsl.framework.zip -d build-macOS-latest/Frameworks
+
       - name: Unzip iOS Framework
         run: |
           unzip build-iOS/lsl.framework.zip -d build-iOS/Frameworks
@@ -188,7 +204,7 @@ jobs:
           APPLE_NOTARIZE_PASSWORD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
         run: |
           xcodebuild -create-xcframework \
-            -framework build-macOS-latest/install/Frameworks/lsl.framework \
+            -framework build-macOS-latest/Frameworks/lsl.framework \
             -framework build-iOS/Frameworks/lsl.framework \
             -output lsl.xcframework