Drop compatibility for old spomky-labs/otphp

Author: scheb

src/google-authenticator/Security/TwoFactor/Provider/Google/GoogleTotpFactory.php

@@ -32,14 +32,7 @@ public function createTotpForUser(TwoFactorInterface $user): TOTPInterface
             throw new TwoFactorProviderLogicException('Cannot initialize TOTP, no secret code provided.');
         }
 
-        // Compatibility for spomky-labs/otphp version 12
-        if ((new ReflectionClass(TOTP::class))->hasProperty('clock')) {
-            /** @psalm-suppress ArgumentTypeCoercion */
-            $totp = TOTP::create($secret, 30, 'sha1', $this->digits, clock: $this->clock);
-        } else {
-            /** @psalm-suppress ArgumentTypeCoercion */
-            $totp = TOTP::create($secret, 30, 'sha1', $this->digits);
-        }
+        $totp = TOTP::create($secret, 30, 'sha1', $this->digits, clock: $this->clock);
 
         $userAndHost = $user->getGoogleAuthenticatorUsername().(null !== $this->server && $this->server ? '@'.$this->server : '');
         $totp->setLabel($userAndHost);

src/totp/Security/TwoFactor/Provider/Totp/TotpFactory.php

@@ -40,25 +40,13 @@ public function createTotpForUser(TwoFactorInterface $user): TOTPInterface
             throw new TwoFactorProviderLogicException('Cannot initialize TOTP, no secret code provided.');
         }
 
-        // Compatibility for spomky-labs/otphp version 12
-        if ((new ReflectionClass(TOTP::class))->hasProperty('clock')) {
-            /** @psalm-suppress ArgumentTypeCoercion */
-            $totp = TOTP::create(
-                $secret,
-                $totpConfiguration->getPeriod(),
-                $totpConfiguration->getAlgorithm(),
-                $totpConfiguration->getDigits(),
-                clock: $this->clock,
-            );
-        } else {
-            /** @psalm-suppress ArgumentTypeCoercion */
-            $totp = TOTP::create(
-                $secret,
-                $totpConfiguration->getPeriod(),
-                $totpConfiguration->getAlgorithm(),
-                $totpConfiguration->getDigits(),
-            );
-        }
+        $totp = TOTP::create(
+            $secret,
+            $totpConfiguration->getPeriod(),
+            $totpConfiguration->getAlgorithm(),
+            $totpConfiguration->getDigits(),
+            clock: $this->clock,
+        );
 
         $userAndHost = $user->getTotpAuthenticationUsername().(null !== $this->server && $this->server ? '@'.$this->server : '');
         $totp->setLabel($userAndHost);