Address Psalm issues

Author: scheb

psalm.xml

@@ -7,6 +7,7 @@
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
 	findUnusedBaselineEntry="true"
 	findUnusedCode="false"
+	ensureOverrideAttribute="false"
 	phpVersion="8.3"
 >
     <projectFiles>
@@ -38,5 +39,7 @@
 				<referencedClass name="Text_Template"/>
 			</errorLevel>
 		</UndefinedDocblockClass>
+		<!-- Breaking change, final keywords to be added in next major version -->
+		<ClassMustBeFinal errorLevel="info" />
 	</issueHandlers>
 </psalm>

src/analyzer/Report/Html/Renderer/DashboardRenderer.php

@@ -73,8 +73,8 @@ public function generate(AnalyzerResult $result): void
         $numDeleted = \count($result->getDeleted());
         $total = $numDead + $numUndead;
 
-        $deadPercent = $total ? $numDead / $total * 100 : 0;
-        $undeadPercent = $total ? $numUndead / $total * 100 : 0;
+        $deadPercent = $total ? (float) $numDead / (float) $total * 100.0 : 0.0;
+        $undeadPercent = $total ? (float) $numUndead / (float) $total * 100.0 : 0.0;
 
         $this->dashboardTemplate->setVar([
             'path_to_root' => '',

src/analyzer/Report/Html/Renderer/DirectoryItemRenderer.php

@@ -66,7 +66,7 @@ private function renderBar(int $numDead, int $total): string
     {
         $this->barTemplate->setVar([
             'level' => 'success',
-            'percent' => round($numDead / $total * 100, 2),
+            'percent' => round((float) $numDead / (float) $total * 100.0, 2),
         ]);
 
         return $this->barTemplate->render();

src/analyzer/Report/TimePeriodFormatter.php

@@ -20,8 +20,8 @@ public static function formatAge(string $date): ?string
             return 'less than a day';
         }
 
-        $weeksPassed = floor($daysPassed / 7);
-        $daysPassed = $daysPassed % 7;
+        $weeksPassed = (int) floor($daysPassed / 7.0);
+        $daysPassed = (int) $daysPassed % 7;
 
         $timePassed = $daysPassed.' days';
         if ($weeksPassed) {

src/analyzer/Stock/TombstoneNodeVisitor.php

@@ -65,7 +65,7 @@ private function visitClassNode(Class_ $node): void
 
     private function visitMethodNode(ClassMethod $node): void
     {
-        $methodName = $this->currentClass.($node->isStatic() ? '::' : '->').$node->name;
+        $methodName = $this->currentClass.($node->isStatic() ? '::' : '->').(string) $node->name;
         $this->currentMethod[] = $methodName;
     }