Enable php-cs-fixer native_function_invocation

Author: scheb

.php_cs.dist

@@ -2,6 +2,7 @@
 
 $rules = [
     '@Symfony' => true,
+    'native_function_invocation' => ['include' => ['@compiler_optimized'], 'scope' => 'namespaced'],
 ];
 
 $finder = PhpCsFixer\Finder::create()

Controller/FormController.php

@@ -96,7 +96,7 @@ protected function getTemplateVars(Request $request, TwoFactorTokenInterface $to
     {
         $config = $this->twoFactorFirewallContext->getFirewallConfig($token->getProviderKey());
         $pendingTwoFactorProviders = $token->getTwoFactorProviders();
-        $displayTrustedOption = $this->trustedFeatureEnabled && (!$config->isMultiFactor() || 1 === count($pendingTwoFactorProviders));
+        $displayTrustedOption = $this->trustedFeatureEnabled && (!$config->isMultiFactor() || 1 === \count($pendingTwoFactorProviders));
         $authenticationException = $this->getLastAuthenticationException($request->getSession());
         $checkPath = $config->getCheckPath();
         $isRoute = false === strpos($checkPath, '/');

DependencyInjection/Compiler/RememberMeServicesDecoratorCompilerPass.php

@@ -21,7 +21,7 @@ class RememberMeServicesDecoratorCompilerPass implements CompilerPassInterface
     public function process(ContainerBuilder $container)
     {
         // Find all remember-me listener definitions
-        $prefixLength = strlen(self::REMEMBER_ME_LISTENER_ID_PREFIX);
+        $prefixLength = \strlen(self::REMEMBER_ME_LISTENER_ID_PREFIX);
         foreach ($container->getDefinitions() as $definitionId => $definition) {
             if (self::REMEMBER_ME_LISTENER_ID_PREFIX === substr($definitionId, 0, $prefixLength)) {
                 $this->decorateRememberMeServices($container, $definition);

Model/Totp/TotpConfiguration.php

@@ -51,7 +51,7 @@ public function __construct(string $secret, string $algorithm, int $period, int
 
     private static function isValidAlgorithm(string $algorithm): bool
     {
-        return in_array(
+        return \in_array(
             $algorithm,
             [
                 self::ALGORITHM_MD5,

Security/Authentication/Provider/AuthenticationProviderDecorator.php

@@ -81,7 +81,7 @@ public function authenticate(TokenInterface $token)
         $request = $this->requestStack->getMasterRequest();
         $firewallConfig = $this->firewallMap->getFirewallConfig($request);
 
-        if (!in_array(TwoFactorFactory::AUTHENTICATION_PROVIDER_KEY, $firewallConfig->getListeners())) {
+        if (!\in_array(TwoFactorFactory::AUTHENTICATION_PROVIDER_KEY, $firewallConfig->getListeners())) {
             return $token; // This firewall doesn't support two-factor authentication
         }
 

Security/Authentication/Token/TwoFactorToken.php

@@ -115,7 +115,7 @@ private function removeTwoFactorProvider(string $providerName): void
 
     public function allTwoFactorProvidersAuthenticated(): bool
     {
-        return 0 === count($this->twoFactorProviders);
+        return 0 === \count($this->twoFactorProviders);
     }
 
     public function getProviderKey(): string
@@ -167,12 +167,12 @@ public function setAttributes(array $attributes)
 
     public function hasAttribute($name)
     {
-        return array_key_exists($name, $this->attributes);
+        return \array_key_exists($name, $this->attributes);
     }
 
     public function getAttribute($name)
     {
-        if (!array_key_exists($name, $this->attributes)) {
+        if (!\array_key_exists($name, $this->attributes)) {
             throw new \InvalidArgumentException(sprintf('This token has no "%s" attribute.', $name));
         }
 

Security/Authorization/TwoFactorAccessDecider.php

@@ -65,11 +65,11 @@ public function isAccessible(Request $request, TokenInterface $token): bool
     private function makeRelativeToBaseUrl(string $logoutPath, Request $request): string
     {
         $baseUrl = $request->getBaseUrl();
-        if (null === $baseUrl || 0 === strlen($baseUrl)) {
+        if (null === $baseUrl || 0 === \strlen($baseUrl)) {
             return $logoutPath;
         }
 
-        $pathInfo = substr($logoutPath, strlen($baseUrl));
+        $pathInfo = substr($logoutPath, \strlen($baseUrl));
         if (false === $pathInfo || '' === $pathInfo) {
             return '/';
         }

Security/TwoFactor/AuthenticationContext.php

@@ -39,7 +39,7 @@ public function getToken(): TokenInterface
 
     public function getUser()
     {
-        if (is_object($user = $this->token->getUser())) {
+        if (\is_object($user = $this->token->getUser())) {
             return $user;
         }
 

Security/TwoFactor/Handler/AuthenticatedTokenHandler.php

@@ -39,6 +39,6 @@ public function beginTwoFactorAuthentication(AuthenticationContextInterface $con
 
     private function isTwoFactorAuthenticationEnabledForToken(TokenInterface $token): bool
     {
-        return in_array(get_class($token), $this->supportedTokens);
+        return \in_array(\get_class($token), $this->supportedTokens);
     }
 }

Security/TwoFactor/Provider/TwoFactorProviderPreparationRecorder.php

@@ -25,7 +25,7 @@ public function isProviderPrepared(string $firewallName, string $providerName):
         $calledProviders = $this->session->get(self::CALLED_PROVIDERS_SESSION_KEY, []);
         $firewallCalledProviders = $calledProviders[$firewallName] ?? [];
 
-        return in_array($providerName, $firewallCalledProviders, true);
+        return \in_array($providerName, $firewallCalledProviders, true);
     }
 
     public function recordProviderIsPrepared(string $firewallName, string $providerName): void