Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

Commit 58c7e93

Browse files
committed
Add CONTRIBUTING.md
1 parent 93f3762 commit 58c7e93

File tree

3 files changed

+37
-13
lines changed

3 files changed

+37
-13
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
/.php_cs.dist export-ignore
99
/.scrutinizer.yml export-ignore
1010
/.travis.yml export-ignore
11+
/CONTRIBUTING.md export-ignore
1112
/LICENSE export-ignore
1213
/php_cs.xml export-ignore
1314
/phpunit.xml.dist export-ignore

CONTRIBUTING.md

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
Contributing
2+
============
3+
👍🎉 First off, thanks for taking the time to contribute! 🎉👍
4+
5+
Submitting a Bug Report
6+
-----------------------
7+
8+
Before you report a bug, please check the [troubleshooting guide](Resources/doc/troubleshooting.md) first.
9+
10+
When creating the bug report, please follow the bug template and provide details about the Symfony and bundle version
11+
you're using.
12+
13+
Creating a Pull Request
14+
-----------------------
15+
16+
You're welcome to [contribute](https://github.com/scheb/two-factor-bundle/graphs/contributors) new features by creating
17+
a pull requests or feature request in the issues section. Besides new features, [translations](Resources/translations)
18+
are highly welcome.
19+
20+
For pull requests, please follow these guidelines:
21+
22+
- Symfony code style (use `php_cs.xml` to configure the code style in your IDE)
23+
- PHP7.1 type hints for everything (including: return types, `void`, nullable types)
24+
- `declare(strict_types=1)` must be used
25+
- Please add/update test cases
26+
- Test methods should be named `[method]_[scenario]_[expected result]`
27+
28+
### Running Quality Checks
29+
30+
Before you create a pull request, please make sure your changes fulfill the
31+
32+
1) Install the dependencies with `composer install`
33+
2) Run the PHPUnit tests with `bin/phpunit`

README.md

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -62,20 +62,10 @@ authentication. ([#143](https://github.com/scheb/two-factor-bundle/issues/143))
6262
- Before versions 3.26.0 / 4.11.0 it was possible to bypass two-factor authentication when the remember-me option is
6363
available on the login form. ([#253](https://github.com/scheb/two-factor-bundle/issues/253))
6464

65-
Contribute
66-
----------
67-
You're welcome to [contribute](https://github.com/scheb/two-factor-bundle/graphs/contributors) to this bundle by
68-
creating a pull requests or feature request in the issues section. For pull requests, please follow these guidelines:
65+
Contributing
66+
------------
6967

70-
- Symfony code style (use `php_cs.xml` to configure the code style in your IDE)
71-
- PHP7.1 type hints for everything (including: return types, `void`, nullable types)
72-
- `declare(strict_types=1)` must be used
73-
- Please add/update test cases
74-
- Test methods should be named `[method]_[scenario]_[expected result]`
75-
76-
Besides new features, [translations](Resources/translations) are highly welcome.
77-
78-
To run the test suite install the dependencies with `composer install` and then execute `bin/phpunit`.
68+
See [CONTRIBUTING.md](CONTRIBUTING.md).
7969

8070
License
8171
-------

0 commit comments

Comments
 (0)