Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

Commit 9c58ef9

Browse files
committed
Add CONTRIBUTING.md
1 parent 636af18 commit 9c58ef9

File tree

3 files changed

+37
-12
lines changed

3 files changed

+37
-12
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
/.php_cs.dist export-ignore
99
/.scrutinizer.yml export-ignore
1010
/.travis.yml export-ignore
11+
/CONTRIBUTING.md export-ignore
1112
/LICENSE export-ignore
1213
/phpunit.xml.dist export-ignore
1314
/README.md export-ignore

CONTRIBUTING.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
Contributing
2+
============
3+
👍🎉 First off, thanks for taking the time to contribute! 🎉👍
4+
5+
Submitting a Bug Report
6+
-----------------------
7+
8+
Before you report a bug, please check the [troubleshooting guide](Resources/doc/troubleshooting.md) first.
9+
10+
When creating the bug report, please follow the bug template and provide details about the Symfony and bundle version
11+
you're using.
12+
13+
Creating a Pull Request
14+
-----------------------
15+
16+
You're welcome to [contribute](https://github.com/scheb/two-factor-bundle/graphs/contributors) new features by creating
17+
a pull requests or feature request in the issues section. Besides new features, [translations](Resources/translations)
18+
are highly welcome.
19+
20+
For pull requests, please follow these guidelines:
21+
22+
- Symfony code style
23+
- PHP7.1 type hints for everything (including: return types, `void`, nullable types)
24+
- Please add/update test cases
25+
- Test methods should be named `[method]_[scenario]_[expected result]`
26+
27+
### Running Quality Checks
28+
29+
Before you create a pull request, please make sure your changes fulfill the
30+
31+
1) Install the dependencies with `composer install`
32+
2) Run the PHPUnit tests with `bin/phpunit`

README.md

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ This bundle provides **[two-factor authentication](https://en.wikipedia.org/wiki
1313

1414
It comes with the following two-factor authentication methods:
1515

16+
- [TOTP authentication](https://en.wikipedia.org/wiki/Time-based_One-time_Password_algorithm)
1617
- [Google Authenticator](https://en.wikipedia.org/wiki/Google_Authenticator)
1718
- Authentication code via email
1819

@@ -61,19 +62,10 @@ authentication. ([#143](https://github.com/scheb/two-factor-bundle/issues/143))
6162
- Before versions 3.26.0 / 4.11.0 it was possible to bypass two-factor authentication when the remember-me option is
6263
available on the login form. ([#253](https://github.com/scheb/two-factor-bundle/issues/253))
6364

64-
Contribute
65-
----------
66-
You're welcome to [contribute](https://github.com/scheb/two-factor-bundle/graphs/contributors) to this bundle by
67-
creating a pull requests or feature request in the issues section. For pull requests, please follow these guidelines:
65+
Contributing
66+
------------
6867

69-
- Symfony code style
70-
- PHP7.1 type hints for everything (including: return types, `void`, nullable types)
71-
- Please add/update test cases
72-
- Test methods should be named `[method]_[scenario]_[expected result]`
73-
74-
Besides new features, [translations](Resources/translations) are highly welcome.
75-
76-
To run the test suite install the dependencies with `composer install` and then execute `bin/phpunit`.
68+
See [CONTRIBUTING.md](CONTRIBUTING.md).
7769

7870
License
7971
-------

0 commit comments

Comments
 (0)