Fix issue where @typescript-eslint/recommended rules were not included

Author: mderazon

README.md

@@ -4,7 +4,7 @@
 
 > ESLint configuration for services built with Node.js and TypeScript.
 
-The configuration extends `@typescript-eslint/recommended`, `eslint-plugin-sonarjs`, `prettier` ESLint configurations.
+The configuration exports and extends `@typescript-eslint/recommended`, `eslint-plugin-sonarjs`, `prettier` ESLint configurations.
 
 It is compatible with ESlint >= v9 configuration format (flat config).
 
@@ -20,7 +20,7 @@ Note that it requires ESlint v9 and above.
 
 ## Usage
 
-Import the package inside of an eslint.config.js file and add it into the exported array, like this:
+Import the package inside of an `eslint.config.js` file and add it into the exported array, like this:
 
 ```js
 // eslint.config.js

index.js

@@ -1,12 +1,12 @@
-import js from "@eslint/js";
-import prettierConfig from "eslint-config-prettier";
-import * as typescriptEslintPlugin from "@typescript-eslint/eslint-plugin";
-import tsParser from "@typescript-eslint/parser";
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
 import sonarjs from "eslint-plugin-sonarjs";
+import prettierConfig from "eslint-config-prettier";
 import globals from "globals";
 
-export default [
-  js.configs.recommended,
+export default tseslint.config(
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
   sonarjs.configs.recommended,
   prettierConfig,
   {
@@ -18,33 +18,30 @@ export default [
         Atomics: "readonly",
         SharedArrayBuffer: "readonly",
       },
-      parser: tsParser,
       parserOptions: {
         ecmaVersion: 2018,
         sourceType: "module",
       },
     },
-    plugins: {
-      "@typescript-eslint": typescriptEslintPlugin,
-      // sonarjs,
-    },
     rules: {
-      "@typescript-eslint/no-use-before-define": "off",
-      "@typescript-eslint/no-inferrable-types": "off",
+      // base rule needs to be disabled to prevent errors with the ts version
+      // see https://typescript-eslint.io/rules/#extension-rules
+      "no-unused-vars": "off",
       "@typescript-eslint/no-unused-vars": "error",
-      "@typescript-eslint/interface-name-prefix": "off",
+      "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/consistent-type-assertions": [
         "error",
         { assertionStyle: "angle-bracket" },
       ],
-      "@typescript-eslint/no-explicit-any": "off",
-      "@typescript-eslint/explicit-function-return-type": "off",
     },
   },
+  // overriding rules specifically for test files
   {
     files: ["**/*(specs|tests)/**", "**/*.spec.ts"],
     rules: {
       "@typescript-eslint/no-empty-function": "off",
+      "sonarjs/no-identical-functions": "off",
+      "sonarjs/no-duplicate-string": "off",
     },
-  },
-];
+  }
+);

package-lock.json

@@ -14,7 +14,6 @@
   "license": "MIT",
   "dependencies": {
     "@eslint/js": "^9.14.0",
-    "@types/eslint__js": "^8.42.3",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-sonarjs": "^2.0.4",
     "globals": "^15.12.0",

package.json

@@ -52,14 +52,36 @@
   "no-unsafe-optional-chaining": [2],
   "no-unused-labels": [2],
   "no-unused-private-class-members": [2],
-  "no-unused-vars": [2],
+  "no-unused-vars": [0],
   "no-useless-backreference": [2],
   "no-useless-catch": [2],
   "no-useless-escape": [2],
   "no-with": [2],
   "require-yield": [2],
   "use-isnan": [2],
   "valid-typeof": [2],
+  "@typescript-eslint/ban-ts-comment": [2],
+  "no-array-constructor": [0],
+  "@typescript-eslint/no-array-constructor": [2],
+  "@typescript-eslint/no-duplicate-enum-values": [2],
+  "@typescript-eslint/no-empty-object-type": [2],
+  "@typescript-eslint/no-explicit-any": [0],
+  "@typescript-eslint/no-extra-non-null-assertion": [2],
+  "@typescript-eslint/no-misused-new": [2],
+  "@typescript-eslint/no-namespace": [2],
+  "@typescript-eslint/no-non-null-asserted-optional-chain": [2],
+  "@typescript-eslint/no-require-imports": [2],
+  "@typescript-eslint/no-this-alias": [2],
+  "@typescript-eslint/no-unnecessary-type-constraint": [2],
+  "@typescript-eslint/no-unsafe-declaration-merging": [2],
+  "@typescript-eslint/no-unsafe-function-type": [2],
+  "no-unused-expressions": [0],
+  "@typescript-eslint/no-unused-expressions": [2],
+  "@typescript-eslint/no-unused-vars": [2],
+  "@typescript-eslint/no-wrapper-object-types": [2],
+  "@typescript-eslint/prefer-as-const": [2],
+  "@typescript-eslint/prefer-namespace-keyword": [2],
+  "@typescript-eslint/triple-slash-reference": [2],
   "sonarjs/anchor-precedence": [2],
   "sonarjs/argument-type": [2],
   "sonarjs/arguments-order": [2],
@@ -565,16 +587,10 @@
   "wrap-regex": [0],
   "yield-star-spacing": [0],
   "react/jsx-space-before-closing": [0],
-  "@typescript-eslint/no-use-before-define": [0],
-  "@typescript-eslint/no-inferrable-types": [0],
-  "@typescript-eslint/no-unused-vars": [2],
-  "@typescript-eslint/interface-name-prefix": [0],
   "@typescript-eslint/consistent-type-assertions": [
     2,
     {
       "assertionStyle": "angle-bracket"
     }
-  ],
-  "@typescript-eslint/no-explicit-any": [0],
-  "@typescript-eslint/explicit-function-return-type": [0]
+  ]
 }