Skip to content

Commit 2c2e616

Browse files
authored
Merge pull request #82 from scheduleonce/hurricanes/story/ONCEHUB-109013-main
Feat: Implemented the placeholder to the select dropdown
2 parents 02bc1bb + 5f4c337 commit 2c2e616

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@oncehub/ui-react",
33
"private": false,
4-
"version": "2.1.3",
4+
"version": "2.1.4",
55
"repository": {
66
"type": "git",
77
"url": "https://github.com/scheduleonce/once-ui-react"

src/lib/components/select/select.module.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
}
1313
.selectValue {
1414
@apply tw-flex tw-items-center;
15+
&.placeholder {
16+
@apply tw-text-[#666666];
17+
}
1518
.seletIcon {
1619
@apply tw-mr-2 tw-h-5 tw-w-5 tw-flex-shrink-0;
1720
}

src/lib/components/select/select.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@ interface Props {
1212
selected: IOption | null;
1313
onSelect: (obj: IOption) => void;
1414
themeColor?: string;
15+
placeholder?: string;
1516
}
1617

1718
interface IDropdownPosition {
1819
left: number;
1920
top: number;
2021
}
2122

22-
export const Select: FC<Props> = ({ children, selected, onSelect, themeColor }) => {
23+
export const Select: FC<Props> = ({ children, selected, onSelect, themeColor, placeholder }) => {
2324
const [isMounted, setIsMounted] = useState(false);
2425
const [open, setOpen] = useState(false);
2526
const [isFocused, setIsFocused] = useState(false);
@@ -138,11 +139,13 @@ export const Select: FC<Props> = ({ children, selected, onSelect, themeColor })
138139
borderBottomColor: themeColor && (isFocused || headlessOpen) ? borderColor : '',
139140
}}
140141
>
141-
{selected && (
142+
{selected ? (
142143
<span className={styles.selectValue}>
143144
{selected.avatar && <img src={selected.avatar} alt="" className={styles.seletIcon} />}
144145
<span className={styles.selectText}>{selected.label}</span>
145146
</span>
147+
) : (
148+
placeholder && <span className={`${styles.selectValue} ${styles.placeholder}`}>{placeholder}</span>
146149
)}
147150
<span className={styles.chevronDownIconSpan}>
148151
<ChevronDownIcon

0 commit comments

Comments
 (0)