Skip to content

Commit b7ff0bd

Browse files
Merge pull request #100 from scheduleonce/technocrats/ONCEHUB-108374-team
feat: [Team] ONCEHUB-98788: updating transformer version to
2 parents 711b1e3 + 8e56ac1 commit b7ff0bd

File tree

518 files changed

+63390
-8997
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

518 files changed

+63390
-8997
lines changed
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
---
2+
alwaysApply: false
3+
---
4+
# PR Review Comments Handler
5+
6+
When addressing PR review comments, follow this systematic approach:
7+
8+
## 1. Checkout the PR Branch
9+
10+
11+
## 2. Get PR Comments
12+
Retrieve all comments on the PR.
13+
14+
## 3. Process Each Comment Sequentially
15+
16+
For **EACH** comment, follow this exact process:
17+
18+
### Step A: Display Comment Information
19+
Print the comment in this format:
20+
```
21+
(index). From [user] on [file]:[lines] — [body]
22+
```
23+
24+
### Step B: Analyze the Context
25+
- Read the file and understand the line range mentioned
26+
- Understand the code context around the comment
27+
- Identify what change is being requested
28+
29+
### Step C: Decision Making
30+
**If you don't understand the comment:**
31+
- Do NOT make any changes
32+
- Ask the user for clarification
33+
- Or ask the user to implement it themselves
34+
- Move to the next comment
35+
36+
**If you understand the comment:**
37+
- Make the change BEFORE moving to the next comment
38+
- Ensure the change addresses the specific feedback
39+
- Test that the change doesn't break existing functionality
40+
41+
### Step D: Move to Next Comment
42+
Only after completing the current comment (either by making a change or asking for clarification), move to the next comment.
43+
44+
## 4. Final Summary
45+
After processing all comments:
46+
- Summarize what changes were made
47+
- List which comments need the USER's attention (clarification needed or user implementation required)
48+
- Provide a clear status of the PR review process
49+
50+
## Important Notes:
51+
- Process comments **one at a time** - don't batch changes
52+
- Always understand the context before making changes
53+
- When in doubt, ask for clarification rather than guessing
54+
- Keep track of which comments were addressed vs. need user attention

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"@typescript-eslint/no-shadow": "error",
6565
"@typescript-eslint/no-loop-func": "error",
6666
"sonarjs/no-same-line-conditional": "error",
67-
"no-restricted-syntax": "error",
67+
"no-restricted-syntax": ["error", "ForInStatement"],
6868
"sonarjs/no-duplicate-string": "error",
6969
"sonarjs/no-identical-functions": "error",
7070
"no-prototype-builtins": "off",

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Bug report
33
about: Create a report to help us improve
44
title: 'BUG: '
55
labels: ''
6-
assignees: ItsSudip, krishna2020, sandeepdsvs, shrouti1507
6+
assignees: '@rudderlabs/integrations, ItsSudip, krishna2020'
77
---
88

99
**Describe the bug**

.github/actions/restart-deployment/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ inputs:
2121
runs:
2222
using: 'composite'
2323
steps:
24-
- uses: azure/setup-kubectl@v4
24+
- uses: azure/setup-kubectl@776406bce94f63e41d621b960d78ee25c8b76ede # v4.0.1
2525

2626
- name: Configure AWS Credentials
27-
uses: aws-actions/configure-aws-credentials@v4
27+
uses: aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4.3.1
2828
with:
2929
role-to-assume: ${{ inputs.aws-role }}
3030
role-session-name: GitHubActionsEKS

0 commit comments

Comments
 (0)