[feature][QuoteBuffer]: Remove redundant buffer initialization and implement empty/clear methods

               Removed unnecessary m_buffer.clear() from QuoteBuffer constructor, as std::string is default-initialized to empty.
               Added thread-safe empty() and clear() methods to QuoteBuffer for checking and resetting buffer content.
               Updated documentation for new methods

Signed-off-by: Goran Mišković <[email protected]>

Author: schkovich

include/QuoteBuffer.hpp

@@ -37,7 +37,7 @@ namespace e5 {
      */
     class QuoteBuffer final : public SyncBridge {
 
-            std::string m_buffer{}; ///< The internal string buffer
+            std::string m_buffer; ///< The internal string buffer
 
             /**
              * @struct BufferPayload
@@ -117,8 +117,15 @@ namespace e5 {
              */
             void append(std::string data);
 
-            // Shared end-of-quote marker for QOTD protocol
-            static constexpr const char* END_OF_QUOTE_MARKER = "\n--- End of Quote ---\n";
+            /**
+             * @brief Returns true if the buffer is empty, false otherwise.
+             */
+            bool empty();
+
+            /**
+             * @brief Clears the buffer content.
+             */
+            void clear();
     };
 
 } // namespace e5

src/QuoteBuffer.cpp

@@ -21,11 +21,7 @@ namespace e5 {
      *
      * @param ctx Shared context manager for synchronized execution
      */
-    QuoteBuffer::QuoteBuffer(const AsyncCtx &ctx) : SyncBridge(ctx) {
-        // Initialize with an empty string to ensure it's properly
-        // null-terminated
-        m_buffer.clear();
-    }
+    QuoteBuffer::QuoteBuffer(const AsyncCtx &ctx) : SyncBridge(ctx) {}
 
     /**
      * @brief Executes buffer operations in a thread-safe manner
@@ -126,4 +122,44 @@ namespace e5 {
         }
     }
 
+    /**
+     * @brief Checks if the buffer is empty
+     *
+     * This method checks if the current buffer content is empty.
+     * Thread-safe through SyncBridge integration, can be called from any core
+     * or interrupt context.
+     *
+     * @return true if the buffer is empty, false otherwise
+     */
+    bool QuoteBuffer::empty() {
+        std::string result_string;
+        auto payload = std::make_unique<BufferPayload>();
+        payload->op = BufferPayload::GET;
+        payload->result_ptr = &result_string;
+        if (const auto result = execute(std::move(payload));
+            result != PICO_OK) {
+            DEBUGV("[c%d][%llu][ERROR] QuoteBuffer::empty() returned error %d.\n",
+                   rp2040.cpuid(), time_us_64(), result);
+        }
+        return result_string.empty();
+    }
+
+    /**
+     * @brief Clears the buffer content
+     *
+     * This method removes the current buffer content, making the buffer empty.
+     * Thread-safe through SyncBridge integration, can be called from any core
+     * or interrupt context.
+     */
+    void QuoteBuffer::clear() {
+        auto payload = std::make_unique<BufferPayload>();
+        payload->op = BufferPayload::SET;
+        payload->data = "";
+        if (const auto result = execute(std::move(payload));
+            result != PICO_OK) {
+            DEBUGV("[c%d][%llu][ERROR] QuoteBuffer::clear() returned error %d.\n",
+                   rp2040.cpuid(), time_us_64(), result);
+        }
+    }
+
 } // namespace e5