Skip to content

Commit 65f83e5

Browse files
author
Natalie Arellano
committed
Updates from PR review
Signed-off-by: Natalie Arellano <[email protected]>
1 parent cac7440 commit 65f83e5

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

content/docs/extension-author-guide/create-extension/building-blocks-extension.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ weight=403
77

88
`tree $workspace/samples/extensions/tree`
99

10-
You should see something akin to the following:
10+
(That's right, we're using the very tool we will later be installing!) You should see something akin to the following:
1111

1212
```
1313
.

content/docs/extension-author-guide/create-extension/run-dockerfile.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Successfully built image hello-extensions
8686
You should see something akin to:
8787

8888
```
89-
curl 7.85.0-DEV (x86_64-pc-linux-musl)
89+
curl 7.85.0-DEV (x86_64-pc-linux-musl) ... more stuff here ...
9090
```
9191

9292
What happened: now that `hello-extensions` requires both `tree` and `curl` in its build plan, both extensions are

content/docs/extension-author-guide/create-extension/why-dockerfiles.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Let's see a build that requires base image extension in order to succeed.
99

1010
#### detect
1111

12-
`cat $workspace/samples/buildpacks/hello-extensions/bin/detect` - the buildpack always detects but doesn't require any
13-
dependencies (as the output build plan is empty)
12+
`cat $workspace/samples/buildpacks/hello-extensions/bin/detect` - the buildpack always detects (because its exit code is `0`)
13+
but doesn't require any dependencies (as the output build plan is empty)
1414

1515
#### build
1616

@@ -21,8 +21,8 @@ phase, and defines a launch process called `curl` that runs `curl --version` at
2121

2222
1. Ensure experimental features are enabled: `pack config experimental true`
2323

24-
2. Download the latest lifecycle tarball from the GitHub release
25-
page: https://github.com/buildpacks/lifecycle/releases/tag/v0.15.1
24+
2. Download the latest lifecycle tarball from the GitHub [release page](https://github.com/buildpacks/lifecycle/releases/tag/v0.15.1)
25+
* For linux containers on x86 architectures: `wget https://github.com/buildpacks/lifecycle/releases/download/v0.15.1/lifecycle-v0.15.1+linux.x86-64.tgz`
2626

2727
3. Edit `$workspace/samples/builders/alpine/builder.toml` to add the following at the end of the file:
2828

@@ -33,7 +33,7 @@ uri = <path to lifecycle tarball in previous step>
3333

3434
4. Ensure you are authenticated with an OCI registry: `docker login` should succeed
3535

36-
5. Set your preferred registry namespace: `registry_namespace=<your preferred registry namespace>`
36+
5. Set your preferred registry namespace (typically your username): `registry_namespace=<your preferred registry namespace>`
3737
* For now, it is necessary for the builder to be pushed to a registry for builds with image extensions to succeed
3838

3939
6. Create the builder:

0 commit comments

Comments
 (0)