Skip to content

Commit 87e90a0

Browse files
author
Natalie Arellano
committed
Cleanup some TODOs
Signed-off-by: Natalie Arellano <[email protected]>
1 parent 7c37ccf commit 87e90a0

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

content/docs/features/dockerfiles.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ An image extension could be defined with the following directory:
4747
outputs either or both of `build.Dockerfile` or `run.Dockerfile` for extending the builder or run image,
4848
respectively (in the [initial implementation](#phased-approach), only limited `run.Dockerfile`s are allowed).
4949

50-
For more information, see [authoring an image extension][TODO].
51-
5250
## A platform's perspective
5351

5452
Platforms may wish to use image extensions if they wish to provide the flexibility of modifying base images dynamically
@@ -57,7 +55,7 @@ at build time.
5755
To use image extensions, a platform should do the following:
5856

5957
* Ensure the platform API in use is at least `0.10`
60-
* Include image extensions in the provided builder (see [packaging an image extension][TODO])
58+
* Include image extensions in the provided builder
6159
* When invoking the `detector` binary, include image extensions in `order.toml`
6260
* Note that the new `generate` phase is a sub-task of the `detector` and thus happens automatically after (and in the
6361
same container as) `detect`
@@ -79,7 +77,7 @@ operators should be mindful that:
7977

8078
* Dockerfiles are very powerful - in fact, you can do anything with a Dockerfile! Introducing image extensions into your
8179
CNB builds can eliminate the security and compatibility guarantees that buildpacks provide if not done with great
82-
care. Consult the [guidelines and best practices][TODO] for more information.
80+
care.
8381
* When Dockerfiles are used to switch the run image from that defined on the provided builder, the resulting run image
8482
may not have all the mixins required by buildpacks that detected. Platforms may wish to optionally re-validate mixins
8583
prior to `build` when using extensions.
@@ -168,7 +166,7 @@ uri = <path to lifecycle tarball>
168166

169167
* Ensure experimental features are enabled: `$workspace/pack/out/pack config experimental true`
170168
* Set the lifecycle image for `pack` to use in the untrusted builder workflow (as the trusted workflow that uses
171-
the `creator` is not currently supported): `LIFECYCLE_IMAGE=buildpacksio/lifecycle:0.15.0-rc.1`
169+
the `creator` is not currently supported): `LIFECYCLE_IMAGE=buildpacksio/lifecycle:0.15.0-rc.1` (TODO: update to 0.15.0 when released)
172170
* Build the application image (note that the "source" directory is effectively ignored in our
173171
example): `$workspace/pack/out/pack build hello-extensions --builder $registry_namespace/extensions-builder --lifecycle-image $LIFECYCLE_IMAGE --verbose --pull-policy always`
174172
- you should see:

0 commit comments

Comments
 (0)