Skip to content

Commit bfe3c08

Browse files
author
Natalie Arellano
committed
Remove notes about things not being implemented that are now implemented
Signed-off-by: Natalie Arellano <[email protected]>
1 parent 4d0434e commit bfe3c08

File tree

2 files changed

+5
-32
lines changed

2 files changed

+5
-32
lines changed

content/docs/extension-guide/create-extension/building-blocks-extension.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ You should see something akin to the following:
3838
* Only a limited set of Dockerfile instructions is supported - consult
3939
the [spec](https://github.com/buildpacks/spec/blob/main/image_extension.md)
4040
for further details.
41-
* In the [initial implementation](/docs/features/dockerfiles#phased-approach), `run.Dockerfile` instructions are
42-
limited to a single `FROM` instruction (effectively, it is only possible to switch the run-time base image to a
43-
pre-created image i.e., no dynamic image modification is allowed). Consult
44-
the [spec](https://github.com/buildpacks/spec/blob/main/image_extension.md)
45-
for further details.
4641

4742
We'll take a closer look at the executables for the `vim` extension in the next step.
4843

content/docs/features/dockerfiles.md

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ An image extension could be defined with the following directory:
5656
* `./bin/detect` is invoked during the `detect` phase. It analyzes application source code to determine if the extension
5757
is needed and contributes build plan entries.
5858
* `./bin/generate` is invoked during the `generate` phase (a new lifecycle phase that happens after `detect`). It
59-
outputs either or both of `build.Dockerfile` or `run.Dockerfile` for extending the builder or run image,
60-
respectively (in the [initial implementation](#phased-approach), only limited `run.Dockerfile`s are allowed).
59+
outputs either or both of `build.Dockerfile` or `run.Dockerfile` for extending the builder or run image.
6160

6261
For more information and to see a build in action,
6362
see [authoring an image extension](/docs/extension-guide/create-extension).
@@ -78,30 +77,9 @@ should be **used with great care**. Platform operators should be mindful that:
7877
may not have all the mixins required by buildpacks that detected. Platforms may wish to optionally re-validate mixins
7978
prior to `build` when using extensions.
8079

81-
### Phased approach
80+
### Putting it all together
8281

83-
Some limitations of the initial implementation of the Dockerfiles feature have already been mentioned, and we'll expand
84-
on them here. As this is a large and complicated feature, the implementation has been split into phases in order to
85-
deliver incremental value and gather feedback.
86-
87-
#### Phase 1 (supported in lifecycle `0.15.0` or greater)
88-
89-
One or more `run.Dockerfile`s each containing a single `FROM` instruction can be used to switch the original run image
90-
to a new image (as no image modifications are permitted, there is no need to run `extend` on the run image)
91-
92-
#### Phase 2 (supported in lifecycle `0.15.0` or greater)
93-
94-
One or more `build.Dockerfile`s can be used to extend the builder image
95-
96-
* A new `extend` lifecycle phase is introduced to apply `build.Dockerfile`s from `generate` to the builder image
97-
98-
#### Phase 3 (future)
99-
100-
One or more `run.Dockerfile`s can be used to extend the run image
101-
102-
* The `extend` lifecycle phase can be run in parallel for the builder and run images
103-
104-
The final ordering of lifecycle phases will look something like the following:
82+
The ordering of lifecycle phases looks like the following:
10583

10684
* `analyze`
10785
* `detect` - after standard detection, `detect` will also run extensions' `./bin/generate`; output Dockerfiles are
@@ -116,9 +94,9 @@ For more information, consult the [migration guide](/docs/reference/spec/migrati
11694

11795
#### Platform support for Dockerfiles
11896

119-
Supported (phases 1 and 2):
97+
Supported:
12098

121-
* [pack cli](https://github.com/buildpacks/pack) (version `0.28.0` and above)
99+
* [pack cli](https://github.com/buildpacks/pack) (prefer version `0.30.0` and above)
122100

123101
Needs support:
124102

0 commit comments

Comments
 (0)