Merge pull request #218 from mrkbac/fix-reader-close

schollz · web-flow · commit f13fb152ca2e · 2025-12-26T13:11:13.000-08:00
Always call `bar.Finish()` in `Reader`
diff --git a/progressbar.go b/progressbar.go
@@ -1433,7 +1433,7 @@ func (r *Reader) Read(p []byte) (n int, err error) {
 // Close the reader when it implements io.Closer
 func (r *Reader) Close() (err error) {
 	if closer, ok := r.Reader.(io.Closer); ok {
-		return closer.Close()
+		err = closer.Close()
 	}
 	r.bar.Finish()
 	return

Original file line number	Diff line number	Diff line change
`@@ -1433,7 +1433,7 @@ func (r *Reader) Read(p []byte) (n int, err error) {`
`1433`	`1433`	`// Close the reader when it implements io.Closer`
`1434`	`1434`	`func (r *Reader) Close() (err error) {`
`1435`	`1435`	`if closer, ok := r.Reader.(io.Closer); ok {`
`1436`		`- return closer.Close()`
	`1436`	`+ err = closer.Close()`
`1437`	`1437`	`}`
`1438`	`1438`	`r.bar.Finish()`
`1439`	`1439`	`return`