fix: use centralized shouldShowSpinner() for all spinner checks

Updated bulk.ts to use the centralized shouldShowSpinner() function instead
of directly checking Deno.stdout.isTerminal(). This ensures progress display
during bulk operations also respects the NO_COLOR environment variable.

Fixes #113

Author: schpet

src/commands/document/document-create.ts

@@ -41,7 +41,6 @@ export const createCommand = new Command()
   .option("--issue <issue:string>", "Attach to issue (identifier like TC-123)")
   .option("--icon <icon:string>", "Document icon (emoji)")
   .option("-i, --interactive", "Interactive mode with prompts")
-  .option("--no-color", "Disable colored output")
   .action(
     async ({
       title,
@@ -51,7 +50,6 @@ export const createCommand = new Command()
       issue,
       icon,
       interactive,
-      color: _colorEnabled,
     }) => {
       const client = getGraphQLClient()
 

src/commands/document/document-delete.ts

@@ -20,7 +20,6 @@ export const deleteCommand = new Command()
   .alias("d")
   .arguments("[documentId:string]")
   .option("-y, --yes", "Skip confirmation prompt")
-  .option("--no-color", "Disable colored output")
   .option(
     "--bulk <ids...:string>",
     "Delete multiple documents by slug or ID",
@@ -32,7 +31,7 @@ export const deleteCommand = new Command()
   .option("--bulk-stdin", "Read document slugs/IDs from stdin")
   .action(
     async (
-      { yes, color: colorEnabled, bulk, bulkFile, bulkStdin },
+      { yes, bulk, bulkFile, bulkStdin },
       documentId,
     ) => {
       const client = getGraphQLClient()
@@ -44,7 +43,6 @@ export const deleteCommand = new Command()
           bulkFile,
           bulkStdin,
           yes,
-          colorEnabled,
         })
         return
       }
@@ -57,15 +55,15 @@ export const deleteCommand = new Command()
         Deno.exit(1)
       }
 
-      await handleSingleDelete(client, documentId, { yes, colorEnabled })
+      await handleSingleDelete(client, documentId, { yes })
     },
   )
 
 async function handleSingleDelete(
   // deno-lint-ignore no-explicit-any
   client: any,
   documentId: string,
-  options: { yes?: boolean; colorEnabled?: boolean },
+  options: { yes?: boolean },
 ): Promise<void> {
   const { yes } = options
 
@@ -144,10 +142,9 @@ async function handleBulkDelete(
     bulkFile?: string
     bulkStdin?: boolean
     yes?: boolean
-    colorEnabled?: boolean
   },
 ): Promise<void> {
-  const { yes, colorEnabled = true } = options
+  const { yes } = options
 
   // Collect all IDs
   const ids = await collectBulkIds({
@@ -245,14 +242,12 @@ async function handleBulkDelete(
   // Execute bulk operation
   const summary = await executeBulkOperations(ids, deleteOperation, {
     showProgress: true,
-    colorEnabled,
   })
 
   // Print summary
   printBulkSummary(summary, {
     entityName: "document",
     operationName: "deleted",
-    colorEnabled,
     showDetails: true,
   })
 

src/commands/document/document-list.ts

@@ -2,6 +2,7 @@ import { Command } from "@cliffy/command"
 import { gql } from "../../__codegen__/gql.ts"
 import { getGraphQLClient } from "../../utils/graphql.ts"
 import { getTimeAgo, padDisplay } from "../../utils/display.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 const ListDocuments = gql(`
   query ListDocuments($filter: DocumentFilter, $first: Int) {
@@ -42,7 +43,7 @@ export const listCommand = new Command()
   .option("--limit <limit:number>", "Limit results", { default: 50 })
   .action(async ({ project, issue, json, limit }) => {
     const { Spinner } = await import("@std/cli/unstable-spinner")
-    const showSpinner = Deno.stdout.isTerminal() && !json
+    const showSpinner = shouldShowSpinner() && !json
     const spinner = showSpinner ? new Spinner() : null
     spinner?.start()
 

src/commands/document/document-update.ts

@@ -99,10 +99,9 @@ export const updateCommand = new Command()
   )
   .option("--icon <icon:string>", "New icon (emoji)")
   .option("-e, --edit", "Open current content in $EDITOR for editing")
-  .option("--no-color", "Disable colored output")
   .action(
     async (
-      { title, content, contentFile, icon, edit, color: _colorEnabled },
+      { title, content, contentFile, icon, edit },
       documentId,
     ) => {
       const client = getGraphQLClient()

src/commands/document/document-view.ts

@@ -4,6 +4,7 @@ import { open } from "@opensrc/deno-open"
 import { gql } from "../../__codegen__/gql.ts"
 import { getGraphQLClient } from "../../utils/graphql.ts"
 import { formatRelativeTime } from "../../utils/display.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 const GetDocument = gql(`
   query GetDocument($id: String!) {
@@ -41,7 +42,7 @@ export const viewCommand = new Command()
   .option("--json", "Output full document as JSON")
   .action(async ({ raw, web, json }, id) => {
     const { Spinner } = await import("@std/cli/unstable-spinner")
-    const showSpinner = Deno.stdout.isTerminal() && !raw && !json
+    const showSpinner = shouldShowSpinner() && !raw && !json
     const spinner = showSpinner ? new Spinner() : null
     spinner?.start()
 

src/commands/initiative-update/initiative-update-create.ts

@@ -4,6 +4,7 @@ import { gql } from "../../__codegen__/gql.ts"
 import { getGraphQLClient } from "../../utils/graphql.ts"
 import { getEditor, openEditor } from "../../utils/editor.ts"
 import { readIdsFromStdin } from "../../utils/bulk.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 const HEALTH_VALUES = ["onTrack", "atRisk", "offTrack"] as const
 type HealthValue = (typeof HEALTH_VALUES)[number]
@@ -101,10 +102,9 @@ export const createCommand = new Command()
     "Health status (onTrack, atRisk, offTrack)",
   )
   .option("-i, --interactive", "Interactive mode with prompts")
-  .option("--no-color", "Disable colored output")
   .action(
     async (
-      { body, bodyFile, health, interactive, color: colorEnabled },
+      { body, bodyFile, health, interactive },
       initiativeId,
     ) => {
       const client = getGraphQLClient()
@@ -152,7 +152,6 @@ export const createCommand = new Command()
           initiativeId: resolvedId,
           body: result.body,
           health: result.health,
-          colorEnabled: colorEnabled !== false,
         })
         return
       }
@@ -211,7 +210,6 @@ export const createCommand = new Command()
         initiativeId: resolvedId,
         body: finalBody,
         health: validatedHealth,
-        colorEnabled: colorEnabled !== false,
       })
     },
   )
@@ -293,13 +291,12 @@ async function createInitiativeUpdate(
     initiativeId: string
     body?: string
     health?: HealthValue
-    colorEnabled: boolean
   },
 ): Promise<void> {
-  const { initiativeId, body, health, colorEnabled } = options
+  const { initiativeId, body, health } = options
 
   const { Spinner } = await import("@std/cli/unstable-spinner")
-  const showSpinner = colorEnabled && Deno.stdout.isTerminal()
+  const showSpinner = shouldShowSpinner()
   const spinner = showSpinner ? new Spinner() : null
   spinner?.start()
 

src/commands/initiative-update/initiative-update-list.ts

@@ -6,6 +6,7 @@ import {
   padDisplay,
   truncateText,
 } from "../../utils/display.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 /**
  * Resolve initiative ID from UUID, slug, or name
@@ -91,7 +92,7 @@ export const listCommand = new Command()
   .option("--limit <limit:number>", "Limit results", { default: 10 })
   .action(async ({ json, limit }, initiativeId) => {
     const { Spinner } = await import("@std/cli/unstable-spinner")
-    const showSpinner = Deno.stdout.isTerminal() && !json
+    const showSpinner = shouldShowSpinner() && !json
     const spinner = showSpinner ? new Spinner() : null
     spinner?.start()
 

src/commands/initiative/initiative-add-project.ts

@@ -1,6 +1,7 @@
 import { Command } from "@cliffy/command"
 import { gql } from "../../__codegen__/gql.ts"
 import { getGraphQLClient } from "../../utils/graphql.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 const AddProjectToInitiative = gql(`
   mutation AddProjectToInitiative($input: InitiativeToProjectCreateInput!) {
@@ -176,10 +177,9 @@ export const addProjectCommand = new Command()
   .description("Link a project to an initiative")
   .arguments("<initiative:string> <project:string>")
   .option("--sort-order <sortOrder:number>", "Sort order within initiative")
-  .option("--no-color", "Disable colored output")
   .action(
     async (
-      { sortOrder, color: colorEnabled },
+      { sortOrder },
       initiativeArg,
       projectArg,
     ) => {
@@ -200,7 +200,7 @@ export const addProjectCommand = new Command()
       }
 
       const { Spinner } = await import("@std/cli/unstable-spinner")
-      const showSpinner = colorEnabled && Deno.stdout.isTerminal()
+      const showSpinner = shouldShowSpinner()
       const spinner = showSpinner ? new Spinner() : null
       spinner?.start()
 

src/commands/initiative/initiative-archive.ts

@@ -9,6 +9,7 @@ import {
   isBulkMode,
   printBulkSummary,
 } from "../../utils/bulk.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 interface InitiativeArchiveResult extends BulkOperationResult {
   name: string
@@ -19,7 +20,6 @@ export const archiveCommand = new Command()
   .description("Archive a Linear initiative")
   .arguments("[initiativeId:string]")
   .option("-y, --force", "Skip confirmation prompt")
-  .option("--no-color", "Disable colored output")
   .option(
     "--bulk <ids...:string>",
     "Archive multiple initiatives by ID, slug, or name",
@@ -31,7 +31,7 @@ export const archiveCommand = new Command()
   .option("--bulk-stdin", "Read initiative IDs from stdin")
   .action(
     async (
-      { force, color: colorEnabled, bulk, bulkFile, bulkStdin },
+      { force, bulk, bulkFile, bulkStdin },
       initiativeId,
     ) => {
       const client = getGraphQLClient()
@@ -43,7 +43,6 @@ export const archiveCommand = new Command()
           bulkFile,
           bulkStdin,
           force,
-          colorEnabled,
         })
         return
       }
@@ -56,17 +55,17 @@ export const archiveCommand = new Command()
         Deno.exit(1)
       }
 
-      await handleSingleArchive(client, initiativeId, { force, colorEnabled })
+      await handleSingleArchive(client, initiativeId, { force })
     },
   )
 
 async function handleSingleArchive(
   // deno-lint-ignore no-explicit-any
   client: any,
   initiativeId: string,
-  options: { force?: boolean; colorEnabled?: boolean },
+  options: { force?: boolean },
 ): Promise<void> {
-  const { force, colorEnabled } = options
+  const { force } = options
 
   // Resolve initiative ID
   const resolvedId = await resolveInitiativeId(client, initiativeId)
@@ -126,7 +125,7 @@ async function handleSingleArchive(
   }
 
   const { Spinner } = await import("@std/cli/unstable-spinner")
-  const showSpinner = colorEnabled && Deno.stdout.isTerminal()
+  const showSpinner = shouldShowSpinner()
   const spinner = showSpinner ? new Spinner() : null
   spinner?.start()
 
@@ -165,10 +164,9 @@ async function handleBulkArchive(
     bulkFile?: string
     bulkStdin?: boolean
     force?: boolean
-    colorEnabled?: boolean
   },
 ): Promise<void> {
-  const { force, colorEnabled = true } = options
+  const { force } = options
 
   // Collect all IDs
   const ids = await collectBulkIds({
@@ -280,14 +278,12 @@ async function handleBulkArchive(
   // Execute bulk operation
   const summary = await executeBulkOperations(ids, archiveOperation, {
     showProgress: true,
-    colorEnabled,
   })
 
   // Print summary
   printBulkSummary(summary, {
     entityName: "initiative",
     operationName: "archived",
-    colorEnabled,
     showDetails: true,
   })
 

src/commands/initiative/initiative-create.ts

@@ -4,6 +4,7 @@ import { gql } from "../../__codegen__/gql.ts"
 import type { InitiativeStatus } from "../../__codegen__/graphql.ts"
 import { getGraphQLClient } from "../../utils/graphql.ts"
 import { lookupUserId } from "../../utils/linear.ts"
+import { shouldShowSpinner } from "../../utils/hyperlink.ts"
 
 const CreateInitiative = gql(`
   mutation CreateInitiative($input: InitiativeCreateInput!) {
@@ -63,7 +64,6 @@ export const createCommand = new Command()
     "-i, --interactive",
     "Interactive mode (default if no flags provided)",
   )
-  .option("--no-color", "Disable colored output")
   .action(async (options) => {
     const {
       name: providedName,
@@ -76,9 +76,6 @@ export const createCommand = new Command()
       interactive: interactiveFlag,
     } = options
 
-    // Note: --no-color flag is separate from --color (hex color) flag
-    // When checking showSpinner, we use Deno.stdout.isTerminal() as the primary check
-
     const client = getGraphQLClient()
     const icon = providedIcon
 
@@ -228,7 +225,7 @@ export const createCommand = new Command()
     }
 
     const { Spinner } = await import("@std/cli/unstable-spinner")
-    const showSpinner = Deno.stdout.isTerminal()
+    const showSpinner = shouldShowSpinner()
     const spinner = showSpinner ? new Spinner() : null
     spinner?.start()