Skip to content

Commit aed8411

Browse files
author
Felix
committed
updated packages + Laravel 5.5 minimum
1 parent 30dd7b6 commit aed8411

File tree

11 files changed

+68
-169
lines changed

11 files changed

+68
-169
lines changed

.gitattributes

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Path-based git attributes
2+
# https://www.kernel.org/pub/software/scm/git/docs/gitattributes.html
3+
4+
# Ignore all test and documentation with "export-ignore".
5+
/.gitattributes export-ignore
6+
/.gitignore export-ignore
7+
/.travis.yml export-ignore
8+
/phpunit.xml.dist export-ignore
9+
/.scrutinizer.yml export-ignore
10+
/tests export-ignore
11+
/.editorconfig export-ignore

.styleci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
preset: psr2
1+
preset: laravel

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ language: php
22
php:
33
- 7.0
44
- 7.1
5+
- 7.2
56

67
env:
78
matrix:

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
All Notable changes to `Laravel AdWords Targeting Idea Service` will be documented in this file.
44

5+
## [1.3.0] - 2017-12-27
6+
- Using version 32.0.0 of googleads/googleads-php-lib
7+
- Require Laravel 5.5
8+
- Removed unused files
9+
- Updated Readme
10+
11+
512
## [1.2.0] - 2017-07-25
613
### Added
714
- Fluent method to convert null values to 0 or empty collection

CONDUCT.md

Lines changed: 0 additions & 74 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 35 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,52 @@
22

33
Contributions are **welcome** and will be fully **credited**.
44

5-
We accept contributions via Pull Requests on [Github](https://github.com/schulzefelix/laravel-adwords-targeting-idea-service).
5+
Please read and understand the contribution guide before creating an issue or pull request.
66

7+
## Etiquette
78

8-
## Pull Requests
9+
This project is open source, and as such, the maintainers give their free time to build and maintain the source code
10+
held within. They make the code freely available in the hope that it will be of use to other developers. It would be
11+
extremely unfair for them to suffer abuse or anger for their hard work.
912

10-
- **[PSR-2 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md)** - Check the code style with ``$ composer check-style`` and fix it with ``$ composer fix-style``.
13+
Please be considerate towards maintainers when raising issues or presenting pull requests. Let's show the
14+
world that developers are civilized and selfless people.
1115

12-
- **Add tests!** - Your patch won't be accepted if it doesn't have tests.
16+
It's the duty of the maintainer to ensure that all submissions to the project are of sufficient
17+
quality to benefit the project. Many developers have different skillsets, strengths, and weaknesses. Respect the maintainer's decision, and do not be upset or abusive if your submission is not used.
1318

14-
- **Document any change in behaviour** - Make sure the `README.md` and any other relevant documentation are kept up-to-date.
19+
## Viability
1520

16-
- **Consider our release cycle** - We try to follow [SemVer v2.0.0](http://semver.org/). Randomly breaking public APIs is not an option.
21+
When requesting or submitting new features, first consider whether it might be useful to others. Open
22+
source projects are used by many developers, who may have entirely different needs to your own. Think about
23+
whether or not your feature is likely to be used by other users of the project.
1724

18-
- **Create feature branches** - Don't ask us to pull from your master branch.
25+
## Procedure
1926

20-
- **One pull request per feature** - If you want to do more than one thing, send multiple pull requests.
27+
Before filing an issue:
2128

22-
- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash them](http://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages) before submitting.
29+
- Attempt to replicate the problem, to ensure that it wasn't a coincidental incident.
30+
- Check to make sure your feature suggestion isn't already present within the project.
31+
- Check the pull requests tab to ensure that the bug doesn't have a fix in progress.
32+
- Check the pull requests tab to ensure that the feature isn't already in progress.
2333

34+
Before submitting a pull request:
2435

25-
## Running Tests
36+
- Check the codebase to ensure that your feature doesn't already exist.
37+
- Check the pull requests to ensure that another person hasn't already submitted the feature or fix.
2638

27-
``` bash
28-
$ composer test
29-
```
39+
## Requirements
3040

41+
If the project maintainer has any additional requirements, you will find them listed here.
42+
43+
- **[PSR-2 Coding Standard](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md)** - The easiest way to apply the conventions is to install [PHP Code Sniffer](http://pear.php.net/package/PHP_CodeSniffer).
44+
45+
- **Document any change in behaviour** - Make sure the `README.md` and any other relevant documentation are kept up-to-date.
46+
47+
- **Consider our release cycle** - We try to follow [SemVer v2.0.0](http://semver.org/). Randomly breaking public APIs is not an option.
48+
49+
- **One pull request per feature** - If you want to do more than one thing, send multiple pull requests.
50+
51+
- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash them](http://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages) before submitting.
3152

32-
**Happy coding**!
53+
**Happy coding**!

ISSUE_TEMPLATE.md

Lines changed: 0 additions & 27 deletions
This file was deleted.

LICENSE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# The MIT License (MIT)
22

3-
Copyright (c) 2016 Felix Schulze <[email protected]>
3+
Copyright (c) 2018 Felix Schulze <[email protected]>
44

55
> Permission is hereby granted, free of charge, to any person obtaining a copy
66
> of this software and associated documentation files (the "Software"), to deal

PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 43 deletions
This file was deleted.

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ This package can be installed through Composer.
1717
$ composer require schulzefelix/laravel-adwords-targeting-idea-service
1818
```
1919

20-
You must install this service provider.
20+
In Laravel 5.5 the package will autoregister the service provider. If package discovery is disabled add the following.
21+
2122
```php
2223
// config/app.php
2324
'providers' => [
@@ -27,7 +28,7 @@ You must install this service provider.
2728
];
2829
```
2930

30-
This package also comes with a facade, which provides an easy way to call the the class.
31+
In Laravel 5.5 the package will autoregister the facade. If package discovery is disabled add the following.
3132

3233
```php
3334
// config/app.php

0 commit comments

Comments
 (0)