A little bit of code maintenance (2nd attempt)#383
Merged
auerswal merged 3 commits intoschweikert:developfrom Apr 6, 2025
Merged
A little bit of code maintenance (2nd attempt)#383auerswal merged 3 commits intoschweikert:developfrom
auerswal merged 3 commits intoschweikert:developfrom
Conversation
Collaborator
auerswal
commented
Mar 8, 2025
auerswal
commented
- move "new features" above "bug fixes and other changes" in CHANGELOG.md
- fix an error message
- test that --icmp-timestamp requires privileges
- fix using dbg_printf() macro in fping.c
Also, add tests with -I. In the currently use GitHub CI system, only GNU/Linux supports this option. But, network device names other than "lo" change too often on GNU/Linux to know in advance what an interface might be called. This limits what can be reliably tested.
config.h must be include before fping.h, because configure --enable-debug writes the DEBUG #define to config.h, and the dbg_printf macro definition requires a defined DEBUG to actually produce any output. Unbreaking dbg_printf() exposed an instance of wrong use, so fix that. Also, add a newline to the debug output reporting used CPU time.
gsnw-sebast
approved these changes
Apr 4, 2025
Collaborator
Author
|
Thanks for the review, @gsnw-sebast! I'll merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.