Merge pull request #2908 from sciencehistory/asset_with_no_content_type_prevents_publishing_work

Asset without a mimetype prevents the work from being published

Author: eddierubeiz

app/controllers/admin/works_controller.rb

@@ -593,9 +593,10 @@ def unpublishable_file_info(work_array)
           problem_asset_ids << asset_id
         end
         # Image assets published as part of a work need to be tiffs, except if they are in an identified special role
-        if mime_type.start_with?('image/') && mime_type != 'image/tiff' && !role.in?(['portrait', 'extracted_pdf_page'])
+        if mime_type.nil? || mime_type.start_with?('image/') && mime_type != 'image/tiff' && !role.in?(['portrait', 'extracted_pdf_page'])
+          problem = mime_type.nil? ? "has no mime_type" : "is a #{mime_type} instead"
           parent = Asset.find_by_friendlier_id(asset_id).parent
-          Rails.logger.warn("Work '#{parent.friendlier_id}' couldn't be published. Asset '#{asset_id}' should be an image/tiff, but is a #{mime_type}.")
+          Rails.logger.warn("Work '#{parent.friendlier_id}' couldn't be published. Asset '#{asset_id}' should be an image/tiff, but #{problem}.")
           problem_works << parent
           problem_asset_ids << asset_id
         end

spec/controllers/admin/works_controller_spec.rb

@@ -170,6 +170,22 @@
       end
     end
 
+
+    context "work with an asset with no mimetype" do
+      let(:no_file_type) { create(:asset_with_faked_file, faked_content_type:nil) }
+      let(:work_with_no_file_type) { create(:work, :with_complete_metadata, published: false, members: [no_file_type]) }
+      before do
+        controller.current_user.works_in_cart << work_with_no_file_type
+      end
+      it "refuses to publish: image assets need to be have a mime type." do
+        expect(no_file_type.content_type).to be_nil
+        put :batch_publish_toggle, params: { publish: "on" }
+        expect(response).to redirect_to(admin_cart_items_path)
+        expect(flash["error"]).to match /contains one or more assets with invalid files./
+        expect(work_with_no_file_type.reload.published?).to be false
+      end
+    end
+
     context "work with a legitimate portrait png" do
       let(:portrait_png) { create(:asset, :inline_promoted_file, role: "portrait") }
       let(:work) { create(:work, :with_complete_metadata, published: false, members: [portrait_png]) }