fix: use FA instead of adding import via isort (#666)

* fix: use FA instead of adding import via isort

Signed-off-by: Henry Schreiner <[email protected]>

* fix: no future needed in pyi

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

docs/pages/guides/style.md

@@ -220,14 +220,17 @@ extend-select = [
   "ARG",      # flake8-unused-arguments
   "B",        # flake8-bugbear
   "C4",       # flake8-comprehensions
+  "DTZ",      # flake8-datetimez
   "EM",       # flake8-errmsg
   "EXE",      # flake8-executable
+  "FA",       # flake8-future-annotations
   "FURB",     # refurb
   "G",        # flake8-logging-format
   "I",        # isort
   "ICN",      # flake8-import-conventions
   "NPY",      # NumPy specific rules
   "PD",       # pandas-vet
+  "PERF",     # perflint
   "PGH",      # pygrep-hooks
   "PIE",      # flake8-pie
   "PL",       # pylint
@@ -237,7 +240,9 @@ extend-select = [
   "RET",      # flake8-return
   "RUF",      # Ruff-specific
   "SIM",      # flake8-simplify
+  "SLOT",     # flake8-slots
   "T20",      # flake8-print
+  "TC",       # flake8-type-checking
   "UP",       # pyupgrade
   "YTT",      # flake8-2020
 ]
@@ -246,7 +251,6 @@ ignore = [
   "PLR2004",  # Magic value used in comparison
 ]
 typing-modules = ["mypackage._compat.typing"]
-isort.required-imports = ["from __future__ import annotations"]
 
 [tool.ruff.lint.per-file-ignores]
 "tests/**" = ["T20"]

helpers/cog_helpers.py

@@ -4,11 +4,11 @@
 import contextlib
 import tempfile
 import typing
-from collections.abc import Generator
 from pathlib import Path
 from types import SimpleNamespace
 
 if typing.TYPE_CHECKING:
+    from collections.abc import Generator
     from typing import Self
 
 from cookiecutter.main import cookiecutter

noxfile.py

@@ -26,12 +26,14 @@
 import urllib.error
 import urllib.request
 import zipfile
-from collections.abc import Callable
 from pathlib import Path
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import nox
 
+if TYPE_CHECKING:
+    from collections.abc import Callable
+
 nox.needs_version = ">=2025.2.9"
 nox.options.default_venv_backend = "uv|virtualenv"
 

pyproject.toml

@@ -153,11 +153,12 @@ messages_control.disable = [
 
 [tool.ruff.lint]
 extend-select = [
-  "B",           # flake8-bugbear
-  "I",           # isort
   "ARG",         # flake8-unused-arguments
+  "B",           # flake8-bugbear
   "C4",          # flake8-comprehensions
   "EM",          # flake8-errmsg
+  "FA",          # flake8-future-annotations
+  "I",           # isort
   "ICN",         # flake8-import-conventions
   "PGH",         # pygrep-hooks
   "PIE",         # flake8-pie
@@ -167,8 +168,9 @@ extend-select = [
   "RET",         # flake8-return
   "RUF",         # Ruff-specific
   "SIM",         # flake8-simplify
-  "TID251",      # flake8-tidy-imports.banned-api
   "T20",         # flake8-print
+  "TC",          # flake8-type-check
+  "TID251",      # flake8-tidy-imports.banned-api
   "UP",          # pyupgrade
   "YTT",         # flake8-2020
 ]

src/sp_repo_review/checks/general.py

@@ -1,10 +1,12 @@
 from __future__ import annotations
 
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from .._compat.importlib.resources.abc import Traversable
+
 # PY: Python Project
 ## 0xx: File existence
 

src/sp_repo_review/checks/github.py

@@ -4,13 +4,15 @@
 from __future__ import annotations
 
 from pathlib import Path
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import yaml
 
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from .._compat.importlib.resources.abc import Traversable
+
 
 def workflows(root: Traversable) -> dict[str, Any]:
     workflows_base_path = root.joinpath(".github/workflows")

src/sp_repo_review/checks/noxfile.py

@@ -7,12 +7,14 @@
 import ast
 import dataclasses
 import re
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 from .._compat import tomllib
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from .._compat.importlib.resources.abc import Traversable
+
 REGEX = re.compile(
     r"(?m)^# /// (?P<type>[a-zA-Z0-9-]+)$\s(?P<content>(^#(| .*)$\s)+)^# ///$"
 )

src/sp_repo_review/checks/precommit.py

@@ -3,13 +3,15 @@
 
 from __future__ import annotations
 
-from typing import Any, ClassVar
+from typing import TYPE_CHECKING, Any, ClassVar
 
 import yaml
 
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from .._compat.importlib.resources.abc import Traversable
+
 
 def precommit(root: Traversable) -> dict[str, Any]:
     precommit_path = root.joinpath(".pre-commit-config.yaml")

src/sp_repo_review/checks/readthedocs.py

@@ -1,12 +1,14 @@
 from __future__ import annotations
 
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import yaml
 
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from .._compat.importlib.resources.abc import Traversable
+
 
 class ReadTheDocs:
     family = "docs"

src/sp_repo_review/checks/ruff.py

@@ -1,12 +1,15 @@
 from __future__ import annotations
 
-from collections.abc import Generator
-from typing import Any, ClassVar, Protocol
+from typing import TYPE_CHECKING, Any, ClassVar, Protocol
 
 from .._compat import tomllib
-from .._compat.importlib.resources.abc import Traversable
 from . import mk_url
 
+if TYPE_CHECKING:
+    from collections.abc import Generator
+
+    from .._compat.importlib.resources.abc import Traversable
+
 ## R0xx: Ruff general
 ## R1xx: Ruff checks
 ## R2xx: Ruff deprecations