Skip to content

Commit 88dc821

Browse files
drammockpre-commit-ci[bot]henryiii
authored
docs: update theme-related text in documentation guide (#437)
* update theme-related text in documentation guide * style: pre-commit fixes * use pydata theme in conf.py too * style: pre-commit fixes * Revert "use pydata theme in conf.py too" This reverts commit 828c44c. * style: pre-commit fixes * chore: disallow RST (-> rST) Signed-off-by: Henry Schreiner <[email protected]> --------- Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Henry Schreiner <[email protected]>
1 parent d7526a2 commit 88dc821

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ repos:
7676
- id: disallow-caps
7777
name: Disallow improper capitalization
7878
language: pygrep
79-
entry: PyBind|Numpy|Cmake|CCache|Github|PyTest
79+
entry: PyBind|Numpy|Cmake|CCache|Github|PyTest|RST
8080
exclude: (.pre-commit-config.yaml|docs/pages/guides/style\.md)$
8181
- id: disallow-bad-permalinks
8282
name: Disallow _ in permalinks

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ for family, grp in itertools.groupby(collected.checks.items(), key=lambda x: x[1
365365
- [`PC111`](https://learn.scientific-python.org/development/guides/style#PC111): Uses blacken-docs
366366
- [`PC140`](https://learn.scientific-python.org/development/guides/style#PC140): Uses mypy
367367
- [`PC160`](https://learn.scientific-python.org/development/guides/style#PC160): Uses codespell
368-
- [`PC170`](https://learn.scientific-python.org/development/guides/style#PC170): Uses PyGrep hooks (only needed if RST present)
368+
- [`PC170`](https://learn.scientific-python.org/development/guides/style#PC170): Uses PyGrep hooks (only needed if rST present)
369369
- [`PC180`](https://learn.scientific-python.org/development/guides/style#PC180): Uses prettier
370370
- [`PC190`](https://learn.scientific-python.org/development/guides/style#PC190): Uses Ruff
371371
- [`PC191`](https://learn.scientific-python.org/development/guides/style#PC191): Ruff show fixes if fixes enabled

docs/pages/guides/docs.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ parent: Topical Guides
1111
# Writing documentation
1212

1313
Documentation used to require learning reStructuredText (sometimes referred to
14-
as reST / RST), but today we have great choices for documentation in markdown,
14+
as reST / rST), but today we have great choices for documentation in markdown,
1515
the same format used by GitHub, Wikipedia, and others. This guide covers Sphinx,
1616
and uses the modern MyST plugin to get Markdown support.
1717

@@ -29,7 +29,7 @@ and uses the modern MyST plugin to get Markdown support.
2929
> based on markdown and HTML. Less support for man pages & PDFs than Sphinx,
3030
> since it doesn't use docutils. Has over
3131
> [200 plugins](https://github.com/mkdocs/catalog) - they are much easier to
32-
> write than Sphinx. Examples include [hatch](https://hatch.pypa.io),
32+
> write than Sphinx. Example sites include [hatch](https://hatch.pypa.io),
3333
> [PDM](https://pdm.fming.dev),
3434
> [cibuildwheel](https://cibuildwheel.readthedocs.io),
3535
> [Textual](https://textual.textualize.io), and
@@ -68,7 +68,7 @@ with render_cookie() as package:
6868

6969
Create `docs/` directory within your project (i.e. next to `src/`). There is a
7070
sphinx-quickstart tool, but it creates unnecessary files (make/bat, we recommend
71-
a cross-platform noxfile instead), and uses RST instead of Markdown. Instead,
71+
a cross-platform noxfile instead), and uses rST instead of Markdown. Instead,
7272
this is our recommended starting point for `conf.py`:
7373

7474
### conf.py
@@ -147,9 +147,10 @@ several good extensions:
147147
We are including both possible file extensions. We are also avoiding some common
148148
file patterns, just in case.
149149

150-
For theme, you have several good options. The clean, light-weight Furo theme is
151-
shown above. Many scientific packages choose the `sphinx-py-data` theme, which
152-
is also a good choice (no dark mode, though).
150+
For theme, many scientific packages choose the
151+
[pydata-sphinx-theme](https://pydata-sphinx-theme.readthedocs.io/). The
152+
[Furo theme](https://pradyunsg.me/furo/) is another popular choice. The site
153+
[sphinx-themes.org](https://sphinx-themes.org/) can be used to compare options.
153154

154155
We are enabling a useful MyST extension: `colon_fence` allows you to use three
155156
colons for directives, which might be highlighted better if the directive

src/sp_repo_review/checks/precommit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class PC160(PreCommit):
9292

9393

9494
class PC170(PreCommit):
95-
"Uses PyGrep hooks (only needed if RST present)"
95+
"Uses PyGrep hooks (only needed if rST present)"
9696

9797
repo = "https://github.com/pre-commit/pygrep-hooks"
9898

0 commit comments

Comments
 (0)