Add check that Deprecated Trove classifiers are not used.

Author: Carreau

pyproject.toml

@@ -10,13 +10,13 @@ authors = [
 ]
 description = "Review repos for compliance to the Scientific-Python development guidelines"
 requires-python = ">=3.10"
+license-expression = 'BSD-3-Clause'
 classifiers = [
   "Development Status :: 4 - Beta",
   "Environment :: Console",
   "Environment :: WebAssembly :: Emscripten",
   "Intended Audience :: Developers",
   "Intended Audience :: Science/Research",
-  "License :: OSI Approved :: BSD License",
   "Operating System :: OS Independent",
   "Programming Language :: Python :: 3",
   "Programming Language :: Python :: 3.10",

src/sp_repo_review/checks/pyproject.py

@@ -94,6 +94,24 @@ def check(pyproject: dict[str, Any], package: Traversable) -> bool | None:
         return None
 
 
+class PP005(PyProject):
+    "Does not have deprecated trove classifiers"
+
+    url = mk_url("packaging-simple")
+
+    @staticmethod
+    def check(pyproject: dict[str, Any], package: Traversable) -> bool | None:
+        """
+        As of Pypi metadata 2.4, all the `License ::` classifiers are deprecated.
+        Prefer the `License-Expression`
+
+        See https://packaging.python.org/en/latest/specifications/core-metadata/#license-expression
+        """
+        match pyproject:
+            case {"project": {"classifiers": classifiers}}:
+                return len([c for c in classifiers if c.startswith("License ::")]) == 0
+
+
 class PP301(PyProject):
     "Has pytest in pyproject"