Skip to content

Commit c3e0a87

Browse files
authored
fix: drop old log level from check (#701)
Signed-off-by: Henry Schreiner <[email protected]>
1 parent a10d869 commit c3e0a87

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/sp_repo_review/checks/pyproject.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ def check(pytest: tuple[PytestFile, dict[str, Any]]) -> bool:
264264
```
265265
"""
266266
_, options = pytest
267-
return "log_cli_level" in options or "log_level" in options
267+
return "log_level" in options
268268

269269

270270
class PP305(PyProject):

tests/test_pyproject.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,11 +278,11 @@ def test_PP304_okay():
278278
assert compute_check("PP304", pytest=(PytestFile.LEGACY_PYPROJECT, toml)).result
279279

280280

281-
def test_PP304_alt_okay():
281+
def test_PP304_alt_not_okay():
282282
toml = toml_loads("""
283283
log_cli_level = "INFO"
284284
""")
285-
assert compute_check("PP304", pytest=(PytestFile.LEGACY_PYPROJECT, toml)).result
285+
assert not compute_check("PP304", pytest=(PytestFile.LEGACY_PYPROJECT, toml)).result
286286

287287

288288
def test_PP304_missing():

0 commit comments

Comments
 (0)