fix(sp-ruff-checks): base indendation on max size (#694)

* fix(sp-ruff-checks): base indendation on max size

Signed-off-by: Henry Schreiner <[email protected]>

* style: pre-commit fixes

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: henryiii

src/sp_repo_review/ruff_checks/__main__.py

@@ -2,7 +2,7 @@
 import importlib.resources
 import json
 import sys
-from collections.abc import Iterator
+from collections.abc import Iterator, Mapping
 from pathlib import Path
 
 from rich import print
@@ -29,10 +29,11 @@
     IGNORE_INFO = json.load(f)
 
 
-def print_each(items: dict[str, str]) -> Iterator[str]:
+def print_each(items: Mapping[str, str]) -> Iterator[str]:
+    size = max(len(k) for k in items) if items else 0
     for k, v in items.items():
         kk = f'[green]"{k}"[/green],'
-        yield f"  {kk:23} [dim]# {v}[/dim]"
+        yield f"  {kk:{size + 18}} [dim]# {v}[/dim]"
 
 
 def process_dir(path: Path) -> None:

src/sp_repo_review/ruff_checks/ignore.json

@@ -20,13 +20,30 @@
     "rule": "RUF009",
     "reason": "Too easy to get a false positive (function call in dataclass defaults)"
   },
-  { "family": "S", "reason": "Some subset is okay" },
+  {
+    "rule": "S101",
+    "family": "S",
+    "reason": "Assert is used by mypy and pytest"
+  },
   { "family": "D", "reason": "Too many doc requests" },
   { "family": "TD", "reason": "Todo format" },
   { "family": "FIX", "reason": "Hacks and todos" },
   { "rule": "TID252", "family": "TID", "reason": "Relative imports are fine" },
-  { "family": "COM", "reason": "Trailing commas teach the formatter" },
-  { "family": "A", "reason": "Okay to shadow builtins" },
+  {
+    "rule": "COM812",
+    "family": "COM",
+    "reason": "Trailing commas teach the formatter"
+  },
+  {
+    "rule": "A002",
+    "family": "A",
+    "reason": "Okay for arguments to shadow builtins"
+  },
+  {
+    "rule": "A003",
+    "family": "A",
+    "reason": "Okay for attributes to shadow builtins"
+  },
   { "rule": "E501", "family": "E", "reason": "Line too long" },
   { "family": "C90", "reason": "Complexity" },
   {