feat: parse project toml files manually #5

savente93 · 2025-08-08T13:25:07Z

Fixes #3

This PR makes quite a few changes but I like this approach:

instead of relying on the tools itself, it just parses the project files, and does the version arithmetic itself.
Stricter bounds and other specifiers are respected
path and url_spec dependencies are also ignored.
This action will open a PR ala dependabot, but for that it does require a token with the correct permissions (unavoidable I think)
There are tests for most of the code, and I've tested it in a dummy repo (https://github.com/savente93/spec_0_test_package) which gives me more confidence in the robustness of this solution.
I went for the 80/20 rule, so this solution works but isn't very feature rich, and takes some shortcuts in places. I think this is a good starting point where things can get added if necessary.
I went with sensible defaults over configuration to keep the first version simple, but I'm open to making it more configurable if that's desirable.

The release_schedule workflow should create the artifacts on this repository so other repositories can access it, and make sure we have a paper trail

Action should create a PR with updated dependencies. Target branch and tool to be used are configurable. Currently only pixi is supported but it's good to make it possible to add other tools down the line

savente93 · 2025-08-15T08:46:44Z

Right, I think it's ready for review now. Smoothed out a few kinks, and made it self testing, which I think is kinda nice. Looking forward to hearing your feedback!

savente93 · 2025-08-19T11:24:05Z

@nabobalis Would you be able to share when you might have time to review the PR? I’ve got a few people I’d like to start using this solution, and I’m hoping to keep up the momentum.

nabobalis

I have not had time to run the code locally, but I am happy to merge and get it going and see what bugs we hit in a live environment.

.github/workflows/release_schedule.yaml

.github/workflows/test.yaml

.github/workflows/test_action.yaml

spec0_action/__init__.py

readme.md

action.yaml

nabobalis · 2025-08-19T18:01:25Z

@nabobalis Would you be able to share when you might have time to review the PR? I’ve got a few people I’d like to start using this solution, and I’m hoping to keep up the momentum.

Hi Sam, sorry about that. I went on vacation, so I just gave it a very quick once over and I am happy to merge and see how it works live.

bsipocz

There are a lot of review comments from both of us, so please don't merge it prematurely, I would rather get this right than fix in production.

action.yaml

pixi.lock

pyproject.toml

bsipocz · 2025-08-19T18:09:33Z

schedule.json

Why is this committed to the repo?

Because it has to be part of the release that the action will check against. We could generate the schedule from scratch every time, but then you lose a paper trail of what was actually in it, so I personally think this solution is better.

generate_schedule.py

update.py

savente93 · 2025-08-19T20:46:46Z

Thanks both, I'll look at it tomorrow, so hopefully the comments will be addressed by the time you wake up again

Co-authored-by: Nabil Freij <[email protected]> Apply suggestions from code review Co-authored-by: Nabil Freij <[email protected]> Apply suggestions from code review Co-authored-by: Brigitta Sipőcz <[email protected]>

savente93

I've addressed all comments I could. There are a few questions still open but hopefully those will be cleared up easily

.github/workflows/test_action.yaml

pixi.lock

action.yaml

pyproject.toml

savente93 · 2025-08-20T07:40:32Z

spec0_action/__init__.py

+
+def update_dependency_table(dep_table: dict, new_versions: dict):
+    for pkg, pkg_data in dep_table.items():
+        # don't do anything for pkgs that aren't in our schedule


hmm, depends on what you're imagining. it could update things that aren't in the schedule potentially but we need to know what to update it too. I'm not entirely sure what you're asking here, if you have a change you want made could you elaborate?

savente93 · 2025-08-20T07:50:52Z

schedule.json

Because it has to be part of the release that the action will check against. We could generate the schedule from scratch every time, but then you lose a paper trail of what was actually in it, so I personally think this solution is better.

savente93 · 2025-08-22T06:42:47Z

@bsipocz I've addressed or responded to your comments. Could you take another look?

savente93 force-pushed the feat/python branch 23 times, most recently from 1a90157 to 68ed38d Compare August 11, 2025 12:25

savente93 marked this pull request as ready for review August 11, 2025 12:36

savente93 added 6 commits August 12, 2025 10:44

feat: release_schedule workflow

ba3ce17

The release_schedule workflow should create the artifacts on this repository so other repositories can access it, and make sure we have a paper trail

feat: have action.yml update pixi environments

30e7fa7

Action should create a PR with updated dependencies. Target branch and tool to be used are configurable. Currently only pixi is supported but it's good to make it possible to add other tools down the line

docs: Update README

0cdba7a

fix: remove now defunct test_action.yaml

2a2b9c0

feat: add python module with helper functions and tests

e6912aa

feat: add main update script

7fee19f

savente93 added 7 commits August 15, 2025 10:09

Merge branch 'main' into feat/python

fd06db1

fix: rename imports

0e0cad5

fix: name issue in workflow

17d74fa

feat: make action test itself

943e9a0

fix: make schedule_path configurable so we can test it

8359b1f

fix: import

533ecca

fix: pass schedule_path to script

4885cc3

savente93 force-pushed the feat/python branch 3 times, most recently from 1d00217 to 33c5e2f Compare August 15, 2025 08:42

fix: fix pr step conditional

a103c2f

savente93 force-pushed the feat/python branch from 33c5e2f to a103c2f Compare August 15, 2025 08:44

Merge branch 'main' into feat/python

5764a23

nabobalis approved these changes Aug 19, 2025

View reviewed changes

bsipocz requested changes Aug 19, 2025

View reviewed changes

savente93 and others added 2 commits August 20, 2025 08:45

Apply suggestions from code review

11f4297

Co-authored-by: Nabil Freij <[email protected]> Apply suggestions from code review Co-authored-by: Nabil Freij <[email protected]> Apply suggestions from code review Co-authored-by: Brigitta Sipőcz <[email protected]>

fix: update authors

1edb4ec

savente93 force-pushed the feat/python branch from 822fd4a to 1edb4ec Compare August 20, 2025 06:45

savente93 added 5 commits August 20, 2025 09:41

fix: release packaging upper pin

30042b8

fix: use SP bot as git name

fa31983

fix: remove pixi.lock

cad5872

fix: rename udpate script

999a1f3

fix: revert rename of versions script

d3f3bb6

savente93 commented Aug 20, 2025

View reviewed changes

savente93 requested a review from bsipocz August 20, 2025 07:51

feat: parse project toml files manually #5

Are you sure you want to change the base?

feat: parse project toml files manually #5

Conversation

savente93 commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

savente93 commented Aug 15, 2025

Uh oh!

savente93 commented Aug 19, 2025

Uh oh!

nabobalis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nabobalis commented Aug 19, 2025

Uh oh!

bsipocz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bsipocz Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

savente93 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

savente93 commented Aug 19, 2025

Uh oh!

savente93 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

savente93 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

savente93 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

savente93 commented Aug 22, 2025

Uh oh!

Uh oh!

savente93 commented Aug 8, 2025 •

edited

Loading