Skip to content

Commit 38444f8

Browse files
authored
Merge pull request #290 from scientist-softserv/code-cleanup
Code cleanup
2 parents 87b8d40 + 19cf86e commit 38444f8

File tree

7 files changed

+26
-20
lines changed

7 files changed

+26
-20
lines changed

.env.local.example

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
NEXTAUTH_SECRET=
2+
NEXTAUTH_URL=
3+
CLIENT_ID=
4+
CLIENT_SECRET=
5+
NEXT_PUBLIC_TOKEN=
6+
7+
# uncomment the “SENTRY” prefixed variables below if you are using sentry and need to catch errors in local dev
8+
# SENTRY_DSN=
9+
# NEXT_PUBLIC_SENTRY_DSN=
10+
# SENTRY_URL=https://sentry.io/
11+
# SENTRY_ORG=
12+
# SENTRY_PROJECT=
13+
# SENTRY_AUTH_TOKEN=

pages/_app.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const WebStore = ({ Component }) => {
3232
navLinks={NAVIGATION_LINKS}
3333
userSession={session}
3434
/>
35-
<Component />
35+
<Component session={session} />
3636
<Footer
3737
color={headerAndFooterLinkColors}
3838
companyName={FOOTER_NAME}

pages/browse/index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { useEffect, useState } from 'react'
22
import { useRouter } from 'next/router'
3-
import { useSession } from 'next-auth/react'
43
import {
54
Item,
65
ItemLoading,
@@ -14,17 +13,17 @@ import {
1413
useFilteredWares,
1514
} from '../../utils'
1615

17-
const Browse = () => {
16+
const Browse = ({ session }) => {
1817
const router = useRouter()
19-
const { data: session } = useSession()
2018
const [query, setQuery] = useState('')
2119
const existingQuery = router.query.q
20+
const accessToken = session?.accessToken
2221

2322
useEffect(() => {
2423
if (existingQuery) setQuery(existingQuery)
2524
}, [existingQuery])
2625

27-
const { wares, isLoading, isError } = useFilteredWares(query, session?.accessToken)
26+
const { wares, isLoading, isError } = useFilteredWares(query, accessToken)
2827
const services = configureServices({ data: wares, path: '/requests/new' })
2928

3029
const handleOnSubmit = ({ value }) => {

pages/requests/[uuid].js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React, { useState, useEffect } from 'react'
22
import { useRouter } from 'next/router'
3-
import { useSession } from 'next-auth/react'
43
import {
54
ActionsGroup,
65
CollapsibleSection,
@@ -28,9 +27,8 @@ import {
2827
useOneRequest,
2928
} from '../../utils'
3029

31-
const Request = () => {
30+
const Request = ({ session }) => {
3231
const router = useRouter()
33-
const { data: session } = useSession()
3432
/**
3533
* as a dynamically routed file, the router query will always consist of a "key: value" pair that's determined by the name of
3634
* the file (key) and path string (value). additional query properties may also exist if they were explicitly passed.

pages/requests/index.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react'
2-
import { useSession } from 'next-auth/react'
32
import { useRouter } from 'next/router'
43
import {
54
LinkedButton,
@@ -15,11 +14,11 @@ import {
1514
useAllRequests
1615
} from '../../utils'
1716

18-
const Requests = () => {
17+
const Requests = ({ session }) => {
1918
const router = useRouter()
20-
const { data: session } = useSession()
21-
const { requests, isLoadingAllRequests, isAllRequestsError } = useAllRequests(session?.accessToken)
22-
const { defaultWareID, isLoadingDefaultWare, isDefaultWareError } = useDefaultWare(session?.accessToken)
19+
const accessToken = session?.accessToken
20+
const { requests, isLoadingAllRequests, isAllRequestsError } = useAllRequests(accessToken)
21+
const { defaultWareID, isLoadingDefaultWare, isDefaultWareError } = useDefaultWare(accessToken)
2322
const isError = isAllRequestsError || isDefaultWareError
2423
const isLoading = isLoadingAllRequests || isLoadingDefaultWare
2524

pages/requests/new/[ware].js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { default as BsForm } from 'react-bootstrap/Form'
33
import Form from '@rjsf/core'
44
import validator from '@rjsf/validator-ajv8'
55
import { useRouter } from 'next/router'
6-
import { useSession } from 'next-auth/react'
76
import {
87
AdditionalInfo,
98
BlankRequestForm,
@@ -23,9 +22,8 @@ import {
2322
useInitializeRequest,
2423
} from '../../../utils'
2524

26-
const NewRequest = () => {
25+
const NewRequest = ({ session }) => {
2726
const router = useRouter()
28-
const { data: session } = useSession()
2927
const accessToken = session?.accessToken
3028
const wareID = router.query.id
3129
const { dynamicForm, isLoadingInitialRequest, isInitialRequestError } = useInitializeRequest(wareID, accessToken)

pages/services/[ware].js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import { useRouter } from 'next/router'
2-
import { useSession } from 'next-auth/react'
32
import { ItemPage, Notice, Loading } from '@scientist-softserv/webstore-component-library'
43
import { configureErrors, DEFAULT_WARE_IMAGE, useOneWare } from '../../utils'
54

6-
const Service = () => {
5+
const Service = ({ session }) => {
76
const router = useRouter()
8-
const { data: session } = useSession()
97
const { id } = router.query
10-
const { ware, isLoading, isError } = useOneWare(id, session?.accessToken)
8+
const accessToken = session?.accessToken
9+
const { ware, isLoading, isError } = useOneWare(id, accessToken)
1110

1211
if (isLoading) return <Loading wrapperClass='item-page mt-5' />
1312

0 commit comments

Comments
 (0)