Skip to content

Commit 73a98d5

Browse files
authored
Merge pull request #349 from scientist-softserv/update-charts-for-gtm
Update charts for google tag manager
2 parents a44a17f + b60eda2 commit 73a98d5

File tree

6 files changed

+6
-5
lines changed

6 files changed

+6
-5
lines changed

.env

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,3 @@ NEXT_PUBLIC_PROVIDER_ID=5159
66
NEXT_PUBLIC_SCIENTIST_API_VERSION=v2
77
NEXT_PUBLIC_WEBHOOK_URL=http://ss-mailer/webstore
88
NEXT_PUBLIC_APP_BASE_URL=https://webstore-staging.vercel.app
9-
10-
# optional/conditional variables
11-
GOOGLE_TAG_MANAGER_ID=GTM-PQGCP24G

charts/webstore/templates/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ spec:
4444
value: "{{ .Values.nextAuthUrl }}"
4545
- name: NEXT_PUBLIC_APP_BASE_URL
4646
value: "{{ .Values.appBaseUrl }}"
47+
- name: NEXT_PUBLIC_GOOGLE_TAG_MANAGER_ID
48+
value: "{{ .Values.googleTagManagerId }}"
4749
- name: NEXT_PUBLIC_PROVIDER_ID
4850
value: "{{ .Values.providerId }}"
4951
- name: NEXT_PUBLIC_PROVIDER_NAME

charts/webstore/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ appBaseUrl: ''
1414
clientId: ''
1515
clientSecret: ''
1616
fullnameOverride: ''
17+
googleTagManagerId: ''
1718
imagePullSecrets: []
1819
nameOverride: ''
1920
nextAuthSecret: ''

ops/production-deploy.tmpl.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
appBaseUrl: 'https://webstore.softserv.cloud'
22
clientId: $CLIENT_ID
33
clientSecret: $CLIENT_SECRET
4+
googleTagManagerId: ''
45
nextAuthSecret: $NEXTAUTH_SECRET
56
nextAuthUrl: 'https://webstore.softserv.cloud/api/auth'
67
nextPublicToken: $NEXT_PUBLIC_TOKEN

ops/staging-deploy.tmpl.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
appBaseUrl: 'https://webstore-staging.softserv.cloud'
22
clientId: $CLIENT_ID
33
clientSecret: $CLIENT_SECRET
4+
googleTagManagerId: ''
45
nextAuthSecret: $NEXTAUTH_SECRET
56
nextAuthUrl: 'https://webstore-staging.softserv.cloud/api/auth'
67
nextPublicToken: $NEXT_PUBLIC_TOKEN

pages/_app.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import {
2121
headerAndFooterLinkColors,
2222
} from '../utils'
2323
import '../utils/theme/globals.scss'
24-
const gtmId = process.env.NODE_ENV === 'production' ? process.env.GOOGLE_TAG_MANAGER_ID : ''
2524

2625
const WebStore = ({ Component }) => {
2726
/**
@@ -42,7 +41,7 @@ const WebStore = ({ Component }) => {
4241
enableCookies={enableCookies}
4342
getCookieConsent={getCookieConsent()}
4443
/> */}
45-
<GoogleTagManager gtmId={gtmId} />
44+
<GoogleTagManager gtmId={process.env.NEXT_PUBLIC_GOOGLE_TAG_MANAGER_ID} />
4645
<Header
4746
auth={{
4847
signIn: () => signIn(process.env.NEXT_PUBLIC_PROVIDER_NAME),

0 commit comments

Comments
 (0)