Skip to content

Commit 985f7e6

Browse files
committed
Updates the deploy to use env variables for the secrets and then defining those secrets so that they will use the helm_deploy envsubst and grab the values from github, we did update github and added the secret values as well
1 parent 22c5c11 commit 985f7e6

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

charts/webstore/templates/deployment.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ spec:
3333
{{- toYaml .Values.securityContext | nindent 12 }}
3434
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
3535
imagePullPolicy: {{ .Values.image.pullPolicy }}
36-
envFrom:
37-
- secretRef:
38-
name: {{ .Values.apiTokenConfigSecret }}
3936
env:
4037
- name: NEXTAUTH_URL
4138
value: "{{ .Values.nextAuthUrl }}"
@@ -45,6 +42,14 @@ spec:
4542
value: "{{ .Values.providerId }}"
4643
- name: NEXT_PUBLIC_SCIENTIST_API_VERSION
4744
value: "{{ .Values.scientistApiVersion }}"
45+
- name: NEXT_PUBLIC_TOKEN
46+
value: "{{ .Values.nextPublicToken }}"
47+
- name: NEXTAUTH_SECRET
48+
value: "{{ .Values.nextAuthSecret }}"
49+
- name: CLIENT_SECRET
50+
value: "{{ .Values.clientSecret }}"
51+
- name: CLIENT_ID
52+
value: "{{ .Values.clientId }}"
4853
ports:
4954
- name: http
5055
containerPort: {{ .Values.service.port }}

ops/staging-deploy.tmpl.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
apiTokenConfigSecret: "webstore-staging-api-tokens"
2+
nextAuthUrl: "https://webstore-staging.notch8.cloud/api/auth"
3+
providerName: "acme"
4+
providerId: "572"
5+
scientistApiVersion: "v2"
6+
nextPublicToken: $NEXT_PUBLIC_TOKEN
7+
nextAuthSecret: $NEXTAUTH_SECRET
8+
clientSecret: $CLIENT_SECRET
9+
clientId: $CLIENT_ID
10+
111
replicaCount: 1
212

313
image:

0 commit comments

Comments
 (0)