ModuleSearchResult: be more defensive when checking menu leaf

imagejan · imagejan · commit 8cc1736a8f8b · 2018-01-12T12:54:59.000+01:00
When info.getMenuPath().getLeaf() was null (as is the case for net.imagej.updater.PromptUserToUpdate), the context() method was throwing a NullPointerException.
Let's be more defensive and avoid calling the toString() method on MenuEntry.
diff --git a/src/main/java/org/scijava/search/module/ModuleSearchResult.java b/src/main/java/org/scijava/search/module/ModuleSearchResult.java
@@ -83,7 +83,7 @@ public String identifier() {
 
 	@Override
 	public String context() {
-		return "/" + getMenuPath(name() != info.getMenuPath().getLeaf().toString(), "/");
+		return "/" + getMenuPath(name() != "" + info.getMenuPath().getLeaf(), "/");
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public String identifier() {`
`83`	`83`
`84`	`84`	`@Override`
`85`	`85`	`public String context() {`
`86`		`- return "/" + getMenuPath(name() != info.getMenuPath().getLeaf().toString(), "/");`
	`86`	`+ return "/" + getMenuPath(name() != "" + info.getMenuPath().getLeaf(), "/");`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`@Override`