Skip to content

Commit ff97035

Browse files
committed
tests: Fix REQUESTED_* handling and remove redundant logic
Fix incorrect use of `IN LISTS` when iterating over hardcoded variable suffixes introduced in edaa1e3 ("tests: Add script-mode tests with support for requested and expected variables", 2025-07-26). Use `IN ITEMS` instead to correctly process REQUESTED_* inputs. With this fix in place, the earlier individual `if()` blocks become redundant and are removed.
1 parent 8e89b64 commit ff97035

File tree

1 file changed

+4
-25
lines changed

1 file changed

+4
-25
lines changed

tests/CMakeLists.txt

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -47,36 +47,15 @@ else()
4747
set(FUNCTIONS_ONLY_COMPONENT_REQUESTED FALSE)
4848
endif()
4949

50-
# Set Vcvars_<varname> based of REQUESTED_<varname>
50+
# Initialize Vcvars_<varname> variables from REQUESTED_<varname> inputs
51+
# unless the "FunctionsOnly" component is being tested
5152
set(requested_vars)
52-
53-
if(DEFINED REQUESTED_MSVC_ARCH AND NOT FUNCTIONS_ONLY_COMPONENT_REQUESTED)
54-
if(REQUESTED_MSVC_ARCH STREQUAL "64")
55-
set(CMAKE_SIZEOF_VOID_P 8)
56-
elseif(REQUESTED_MSVC_ARCH STREQUAL "32")
57-
set(CMAKE_SIZEOF_VOID_P 4)
58-
else()
59-
message(FATAL_ERROR "Variable REQUESTED_MSVC_ARCH is invalid. Expected value 32 or 64")
60-
endif()
61-
list(APPEND requested_vars REQUESTED_MSVC_ARCH)
62-
endif()
63-
64-
if(DEFINED REQUESTED_MSVC_VERSION AND NOT FUNCTIONS_ONLY_COMPONENT_REQUESTED)
65-
set(Vcvars_MSVC_VERSION ${REQUESTED_MSVC_VERSION})
66-
list(APPEND requested_vars REQUESTED_MSVC_VERSION)
67-
endif()
68-
69-
if(DEFINED REQUESTED_FIND_VCVARSALL AND NOT FUNCTIONS_ONLY_COMPONENT_REQUESTED)
70-
set(Vcvars_FIND_VCVARSALL ${REQUESTED_FIND_VCVARSALL})
71-
list(APPEND requested_vars REQUESTED_FIND_VCVARSALL)
72-
endif()
73-
74-
foreach(var_suffix IN LISTS
53+
foreach(var_suffix IN ITEMS
7554
FIND_VCVARSALL
7655
MSVC_ARCH
7756
MSVC_VERSION
7857
)
79-
if(DEFINED REQUESTED_${var_suffix})
58+
if(DEFINED REQUESTED_${var_suffix} AND NOT FUNCTIONS_ONLY_COMPONENT_REQUESTED)
8059
set(Vcvars_${var_suffix} ${REQUESTED_${var_suffix}})
8160
list(APPEND requested_vars REQUESTED_${var_suffix})
8261
endif()

0 commit comments

Comments
 (0)