Skip to content

Commit 75548a4

Browse files
committed
fix: do not require Ninja
This should prevent bootstrapping issues between CMake PyPI distribution and Ninja PyPI distribution when building either one from sources.
1 parent 66eddd4 commit 75548a4

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

pyproject.toml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ ctest = "cmake:ctest"
5454
minimum-version = "0.8"
5555
build-dir = "build/{wheel_tag}"
5656
cmake.version = "" # We are cmake, so don't request cmake
57-
ninja.make-fallback = false
57+
ninja.version = "" # requiring ninja could cause it to request CMake if it needs to be built from sources, fallback to make
58+
ninja.make-fallback = true
5859
wheel.py-api = "py3"
5960
wheel.expand-macos-universal-tags = true
6061
wheel.install-dir = "cmake/data"
@@ -65,6 +66,12 @@ template = '''
6566
version = "${version}"
6667
'''
6768

69+
[[tool.scikit-build.overrides]]
70+
if.env.CIBUILDWHEEL = true
71+
# ninja.version = ">=1.11"
72+
# ninja.make-fallback = false
73+
ninja.version = ""
74+
ninja.make-fallback = true
6875

6976
[tool.cibuildwheel]
7077
build = "cp39-*"

0 commit comments

Comments
 (0)