feat: Add support for using genex in CYTHON_ARGS

Author: jcfr

src/cython_cmake/cmake/UseCython.cmake

@@ -70,8 +70,10 @@
 # limitations under the License.
 #=============================================================================
 
-if(CMAKE_VERSION VERSION_LESS "3.7")
-  message(FATAL_ERROR "CMake 3.7 required for DEPFILE")
+if(CMAKE_VERSION VERSION_LESS "3.8")
+  # CMake 3.7 required for DEPFILE
+  # CMake 3.8 required for COMMAND_EXPAND_LISTS
+  message(FATAL_ERROR "CMake 3.8 required for COMMAND_EXPAND_LISTS")
 endif()
 
 function(Cython_compile_pyx)
@@ -148,10 +150,11 @@ function(Cython_compile_pyx)
       COMMAND
         ${_cython_command}
         ${_language_arg}
-        ${_args_CYTHON_ARGS}
+        "${_args_CYTHON_ARGS}"
         ${_depfile_arg}
         ${pyx_location}
         --output-file ${generated_file}
+      COMMAND_EXPAND_LISTS
       MAIN_DEPENDENCY
         ${_source_file}
       DEPFILE

tests/packages/simple/CMakeLists.txt

@@ -10,7 +10,7 @@ include(UseCython)
 
 cython_compile_pyx(simple.pyx
   LANGUAGE C
-  # OUTPUT_ARG
+  # PLACEHOLDER
   OUTPUT_VARIABLE simple_c
 )
 

tests/test_package.py

@@ -50,7 +50,7 @@ def test_output_argument(monkeypatch, tmp_path, output_arg):
 
     cmakelists = Path("CMakeLists.txt")
     txt = cmakelists.read_text().replace(
-        "# OUTPUT_ARG", f'OUTPUT "{output_values[output_arg]}"'
+        "# PLACEHOLDER", f'OUTPUT "{output_values[output_arg]}"'
     )
     cmakelists.write_text(txt)
 
@@ -133,6 +133,7 @@ def test_multiple_packages(monkeypatch, tmp_path):
     package_dir = tmp_path / "pkg5"
     shutil.copytree(DIR / "packages/multiple_packages", package_dir)
     monkeypatch.chdir(package_dir)
+
     build_dir = tmp_path / "build"
 
     wheel = build_wheel(
@@ -158,3 +159,39 @@ def test_multiple_packages(monkeypatch, tmp_path):
     package3_build_files = {x.name for x in (build_dir / "__").iterdir()}
     assert "module.c.dep" in package3_build_files
     assert "module.c" in package3_build_files
+
+
+def test_genex_cython_args(monkeypatch, tmp_path, capfd):
+    package_dir = tmp_path / "pkg6"
+    shutil.copytree(DIR / "packages/simple", package_dir)
+    monkeypatch.chdir(package_dir)
+
+    build_dir = tmp_path / "build"
+
+    cmakelists = Path("CMakeLists.txt")
+    txt = (
+        cmakelists.read_text()
+        .replace("LANGUAGE C", "")
+        .replace("LANGUAGES C", "LANGUAGES CXX")
+        .replace("# PLACEHOLDER", 'CYTHON_ARGS "$<1:--verbose;--annotate>"')
+    )
+    cmakelists.write_text(txt)
+
+    wheel = build_wheel(
+        str(tmp_path), {"build-dir": str(build_dir), "wheel.license-files": []}
+    )
+
+    with zipfile.ZipFile(tmp_path / wheel) as f:
+        file_names = set(f.namelist())
+    assert len(file_names) == 4
+
+    build_files = {x.name for x in build_dir.iterdir()}
+    assert "simple.cxx.dep" in build_files
+    assert "simple.cxx" in build_files
+
+    # Check side-effect of "--annotate"
+    assert "simple.html" in build_files
+
+    # Check side-effect of "--verbose"
+    captured = capfd.readouterr()
+    assert "Compiling " in captured.out or "Compiling " in captured.err