Skip to content

Conversation

@jcfr
Copy link
Contributor

@jcfr jcfr commented Jul 17, 2024

Integrate changes originally introduced through:


Considering the following comment originally posted by @henryiii in #19 (comment), we are keeping the loop anticipating support for passing multiple input files.

Why would you pass multiple files to cythonize?

It only produces one output. Should we allow multiple files here, and just treat the first one as special? Edit: leaving this off for now. It could be added, it would be incompatible with OUTPUT and a list of files would be placed in OUTPUT_VARIABLE.

@jcfr jcfr force-pushed the simplify-expecting-one-input-file branch from b5e0e64 to cd86550 Compare July 17, 2024 07:04
Remove obsolete ARGS argument that is being ignored and here only for
backward compatibility.

Switch from DEPENDS to MAIN_DEPENDENCY to suggest Visual Studio where to
hang the custom command.

Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
@jcfr jcfr force-pushed the simplify-expecting-one-input-file branch from cd86550 to 275fc2b Compare July 18, 2024 00:03
@jcfr jcfr merged commit bb683a3 into main Jul 18, 2024
@jcfr jcfr deleted the simplify-expecting-one-input-file branch July 18, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants