feat(setuptools): error for cmake_install_target

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

pyproject.toml

@@ -116,6 +116,7 @@ Issues = "https://github.com/scikit-build/scikit-build-core/issues"
 "distutils.commands".build_cmake = "scikit_build_core.setuptools.build_cmake:BuildCMake"
 "distutils.setup_keywords".cmake_source_dir = "scikit_build_core.setuptools.build_cmake:cmake_source_dir"
 "distutils.setup_keywords".cmake_args = "scikit_build_core.setuptools.build_cmake:cmake_args"
+"distutils.setup_keywords".cmake_install_target = "scikit_build_core.setuptools.build_cmake:cmake_install_target"
 "setuptools.finalize_distribution_options".scikit_build_entry = "scikit_build_core.setuptools.build_cmake:finalize_distribution_options"
 "validate_pyproject.tool_schema".scikit-build = "scikit_build_core.settings.skbuild_schema:get_skbuild_schema"
 hatch.scikit-build = "scikit_build_core.hatch.hooks"

src/scikit_build_core/setuptools/build_cmake.py

@@ -58,8 +58,9 @@ def get_source_dir_from_pyproject_toml() -> str | None:
 
 
 class BuildCMake(setuptools.Command):
-    source_dir: str | None = None
+    cmake_source_dir: str | None = None
     cmake_args: list[str] | str | None = None
+    cmake_install_target: str | None = None
 
     build_lib: str | None
     build_temp: str | None
@@ -74,8 +75,9 @@ class BuildCMake(setuptools.Command):
         ("plat-name=", "p", "platform name to cross-compile for, if supported "),
         ("debug", "g", "compile/link with debugging information"),
         ("parallel=", "j", "number of parallel build jobs"),
-        ("source-dir=", "j", "directory with CMakeLists.txt"),
+        ("cmake-source-dir=", "", "directory with CMakeLists.txt"),
         ("cmake-args=", "a", "extra arguments for CMake"),
+        ("cmake-install-target=", "", "CMake target to install"),
     ]
 
     def initialize_options(self) -> None:
@@ -85,8 +87,9 @@ def initialize_options(self) -> None:
         self.editable_mode = False
         self.parallel = None
         self.plat_name = None
-        self.source_dir = get_source_dir_from_pyproject_toml()
+        self.cmake_source_dir = get_source_dir_from_pyproject_toml()
         self.cmake_args = None
+        self.cmake_install_target = None
 
     def finalize_options(self) -> None:
         self.set_undefined_options(
@@ -116,7 +119,9 @@ def run(self) -> None:
 
         dist = self.distribution
         dist_source_dir = getattr(self.distribution, "cmake_source_dir", None)
-        source_dir = self.source_dir if dist_source_dir is None else dist_source_dir
+        source_dir = (
+            self.cmake_source_dir if dist_source_dir is None else dist_source_dir
+        )
         assert source_dir is not None, "This should not be reachable"
 
         configure_args = self.cmake_args or []
@@ -180,7 +185,7 @@ def run(self) -> None:
         builder.build(build_args=build_args)
         builder.install(install_dir=install_dir)
 
-    # def "get_source_file+ys"(self) -> list[str]:
+    # def "get_source_file"(self) -> list[str]:
     #    return ["CMakeLists.txt"]
 
     # def get_outputs(self) -> list[str]:
@@ -194,7 +199,7 @@ def _has_cmake(dist: Distribution) -> bool:
     build_cmake = dist.get_command_obj("build_cmake")
     assert isinstance(build_cmake, BuildCMake)
     return (
-        build_cmake.source_dir is not None
+        build_cmake.cmake_source_dir is not None
         or getattr(dist, "cmake_source_dir", None) is not None
     )
 
@@ -260,3 +265,13 @@ def cmake_source_dir(
     if not Path(value).is_dir():
         msg = "cmake_source_dir must be an existing directory"
         raise setuptools.errors.SetupError(msg)
+
+
+def cmake_install_target(
+    dist: Distribution, attr: Literal["cmake_install_target"], value: str
+) -> None:
+    assert attr == "cmake_install_target"
+    assert value is not None
+    _cmake_extension(dist)
+    msg = "cmake_install_target is not supported - please use components and build targets instead"
+    raise setuptools.errors.SetupError(msg)