Revert "fix: expand some variables when constructing paths" (#846)

Reverts #844

Author: henryiii

docs/changelog.md

@@ -27,7 +27,6 @@ Fixes:
 * Warn if cmake/ninja in build system requirements by @henryiii in #803
 * Detect manual generator setting for `get_requires_*` by @henryiii in #840
 * Support nested and local gitignores by @henryiii in #827
-* Expand variables in some paths (mostly helps tests) by @henryiii in #842
 
 Internal:
 

src/scikit_build_core/program_search.py

@@ -2,7 +2,6 @@
 
 import contextlib
 import json
-import os.path
 import shutil
 import subprocess
 from pathlib import Path
@@ -53,7 +52,7 @@ def _get_cmake_path(*, module: bool = True) -> Generator[Path, None, None]:
     for candidate in candidates:
         cmake_path = shutil.which(candidate)
         if cmake_path is not None:
-            yield Path(os.path.expandvars(cmake_path))
+            yield Path(cmake_path)
 
 
 def _get_ninja_path(*, module: bool = True) -> Generator[Path, None, None]:
@@ -72,7 +71,7 @@ def _get_ninja_path(*, module: bool = True) -> Generator[Path, None, None]:
     for candidate in candidates:
         ninja_path = shutil.which(candidate)
         if ninja_path is not None:
-            yield Path(os.path.expandvars(ninja_path))
+            yield Path(ninja_path)
 
 
 def get_cmake_program(cmake_path: Path) -> Program:
@@ -157,7 +156,7 @@ def get_make_programs() -> Generator[Path, None, None]:
     for candidate in candidates:
         make_path = shutil.which(candidate)
         if make_path is not None:
-            yield Path(os.path.expandvars(make_path))
+            yield Path(make_path)
 
 
 def best_program(

tests/test_cmake_config.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import os
-import os.path
 import shutil
 from pathlib import Path
 from typing import TYPE_CHECKING
@@ -16,7 +15,7 @@
 if TYPE_CHECKING:
     from collections.abc import Generator
 
-DIR = Path(os.path.expandvars(__file__)).parent.resolve()
+DIR = Path(__file__).parent.resolve()
 
 
 def configure_args(config: CMaker, *, init: bool = False) -> Generator[str, None, None]: