chore(deps): update pre-commit hooks (#210)

<!--pre-commit.ci start-->
updates:
- [github.com/charliermarsh/ruff-pre-commit: v0.0.251 →
v0.0.253](astral-sh/ruff-pre-commit@v0.0.251...v0.0.253)
<!--pre-commit.ci end-->

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Henry Schreiner <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -54,7 +54,7 @@ repos:
         exclude: "^tests"
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.251
+    rev: v0.0.253
     hooks:
       - id: ruff
         args: ["--fix", "--show-fixes"]

pyproject.toml

@@ -189,7 +189,13 @@ select = [
     "UP",          # pyupgrade
     "YTT",         # flake8-2020
 ]
-extend-ignore = ["PLR0915", "PLR0912", "PLR2004", "E501"]
+extend-ignore = [
+    "PLR0915",
+    "PLR0912",
+    "PLR2004",
+    "PLE1205",  # Format check doesn't work with our custom logger
+    "E501",  # Line too long
+]
 target-version = "py37"
 typing-modules = ["scikit_build_core._compat.typing"]
 src = ["src"]

src/scikit_build_core/cmake.py

@@ -123,12 +123,12 @@ def init_cache(
         with self.init_cache_file.open("w", encoding="utf-8") as f:
             for key, value in cache_settings.items():
                 if isinstance(value, bool):
-                    value = "ON" if value else "OFF"
-                    f.write(f'set({key} {value} CACHE BOOL "" FORCE)\n')
+                    str_value = "ON" if value else "OFF"
+                    f.write(f'set({key} {str_value} CACHE BOOL "" FORCE)\n')
                 elif isinstance(value, os.PathLike):
                     # Convert to CMake's internal path format
-                    value = str(value).replace("\\", "/")
-                    f.write(f'set({key} [===[{value}]===] CACHE PATH "" FORCE)\n')
+                    str_value = str(value).replace("\\", "/")
+                    f.write(f'set({key} [===[{str_value}]===] CACHE PATH "" FORCE)\n')
                 else:
                     f.write(f'set({key} [===[{value}]===] CACHE STRING "" FORCE)\n')
         contents = self.init_cache_file.read_text(encoding="utf-8").strip()
@@ -152,11 +152,11 @@ def _compute_cmake_args(
 
         for key, value in defines.items():
             if isinstance(value, bool):
-                value = "ON" if value else "OFF"
-                yield f"-D{key}:BOOL={value}"
+                str_value = "ON" if value else "OFF"
+                yield f"-D{key}:BOOL={str_value}"
             elif isinstance(value, os.PathLike):
-                value = str(value).replace("\\", "/")
-                yield f"-D{key}:PATH={value}"
+                str_value = str(value).replace("\\", "/")
+                yield f"-D{key}:PATH={str_value}"
             else:
                 yield f"-D{key}={value}"