Switch to using lief

patchelf is failing on recent Fedora releases

Signed-off-by: Cristian Le <[email protected]>

Author: LecrisUT

pyproject.toml

@@ -68,7 +68,7 @@ test-hatchling = [
 test-meta = [
     "hatch-fancy-pypi-readme>=22.3",
     "setuptools-scm",
-    "auditwheel; platform_system=='Linux'",
+    "lief; platform_system=='Linux'",
     "delocate; platform_system=='Darwin'",
 ]
 test-numpy = [
@@ -191,8 +191,8 @@ module = [
     "setuptools_scm",
     "hatch_fancy_pypi_readme",
     "virtualenv",
-    "auditwheel.*",
     "delocate.*",
+    "lief.*",
 ]
 ignore_missing_imports = true
 
@@ -329,3 +329,6 @@ known-local-folder = ["pathutils"]
 
 [tool.check-sdist]
 sdist-only = ["src/scikit_build_core/_version.py"]
+
+[tool.codespell]
+ignore-words-list = "lief"

src/scikit_build_core/builder/get_requires.py

@@ -5,7 +5,6 @@
 import importlib.util
 import os
 import platform
-import shutil
 import sysconfig
 from typing import TYPE_CHECKING, Literal
 
@@ -150,10 +149,7 @@ def other_dynamic_requires(self) -> Generator[str, None, None]:
         if self.settings.wheel.repair.enable:
             platform_system = platform.system()
             if platform_system == "Linux":
-                yield "auditwheel"
-                patchelf_path = shutil.which("patchelf")
-                if patchelf_path is None:
-                    yield "patchelf"
+                yield "lief"
             elif platform_system == "Darwin":
                 yield "delocate"
 

src/scikit_build_core/repair_wheel/linux.py

@@ -6,7 +6,6 @@
 
 from typing import TYPE_CHECKING
 
-from .._shutil import Run
 from .rpath import RpathWheelRepairer
 
 if TYPE_CHECKING:
@@ -28,17 +27,24 @@ class LinuxWheelRepairer(RpathWheelRepairer):
     _origin_symbol = "$ORIGIN"
 
     def get_library_rpath(self, artifact: Path) -> list[str]:
-        from auditwheel.elfutils import elf_read_rpaths
+        import lief.ELF
 
-        return [
-            path
-            for dt_rpaths in elf_read_rpaths(artifact).values()
-            for path in dt_rpaths
-        ]
+        elf = lief.ELF.parse(artifact)
+        if not elf.has(lief.ELF.DynamicEntry.TAG.RUNPATH):
+            # Early exit if library does not have rpaths
+            return []
+        elf_rpaths = elf.get(lief.ELF.DynamicEntry.TAG.RUNPATH)
+        return list(elf_rpaths.paths)
 
     def patch_library_rpath(self, artifact: Path, rpaths: list[str]) -> None:
         final_rpaths = set(rpaths)
         if final_rpaths:
-            run = Run()
-            run.live("patchelf", "--remove-rpath", artifact)
-            run.live("patchelf", "--set-rpath", ":".join(final_rpaths), artifact)
+            import lief.ELF
+
+            elf_rpaths = lief.ELF.DynamicEntryRunPath()
+            for rpath in final_rpaths:
+                elf_rpaths.append(rpath)
+            elf = lief.ELF.parse(artifact)
+            elf.remove(lief.ELF.DynamicEntry.TAG.RUNPATH)
+            elf.add(elf_rpaths)
+            elf.write(str(artifact))

tests/conftest.py

@@ -55,8 +55,7 @@ def pep518_wheelhouse(tmp_path_factory: pytest.TempPathFactory) -> Path:
         "wheel",
     ]
     if platform.system() == "Linux":
-        packages.append("auditwheel")
-        packages.append("patchelf")
+        packages.append("lief")
     if platform.system() == "Darwin":
         packages.append("delocate")
 

tests/test_repair_wheel.py

@@ -1,5 +1,4 @@
 import platform
-import shutil
 from pathlib import Path
 
 import pytest
@@ -47,9 +46,7 @@ def test_full_build(
     if not with_isolation:
         isolated.install("scikit-build-core")
         if platform.system() == "Linux":
-            isolated.install("auditwheel")
-            if shutil.which("patchelf") is None:
-                isolated.install("patchelf")
+            isolated.install("lief")
         if platform.system() == "Darwin":
             isolated.install("delocate")
         isolated.install("./extern", isolated=with_isolation)