Skip to content

Commit 9df0b29

Browse files
committed
fix: cleanup some changes
Signed-off-by: Henry Schreiner <[email protected]>
1 parent 1d96bc0 commit 9df0b29

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

src/scikit_build_core/_logging.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
import platform
1010
import sys
1111
from collections.abc import Mapping
12-
from typing import TYPE_CHECKING, Any, NoReturn
12+
from typing import TYPE_CHECKING, Any, Literal, NoReturn
1313

1414
if TYPE_CHECKING:
1515
from collections.abc import Iterator
1616

17-
from ._compat.typing import Literal, Self
17+
from ._compat.typing import Self
1818

1919
StrMapping = Mapping[str, "Style"]
2020
else:

src/scikit_build_core/builder/sysconfig.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import sys
66
import sysconfig
77
from pathlib import Path
8-
from typing import TYPE_CHECKING
8+
from typing import TYPE_CHECKING, Literal
99

1010
import packaging.tags
1111

@@ -14,8 +14,6 @@
1414
if TYPE_CHECKING:
1515
from collections.abc import Mapping
1616

17-
from .._compat.typing import Literal
18-
1917
__all__ = [
2018
"get_abi_flags",
2119
"get_cmake_platform",
@@ -169,7 +167,13 @@ def get_soabi(env: Mapping[str, str], *, abi3: bool = False) -> str:
169167
if setuptools_ext_suffix:
170168
return setuptools_ext_suffix.rsplit(".", 1)[0].lstrip(".")
171169

172-
ext_suffix = sysconfig.get_config_var("EXT_SUFFIX")
170+
if sys.version_info < (3, 8, 7):
171+
# See https://github.com/python/cpython/issues/84006
172+
import distutils.sysconfig # pylint: disable=deprecated-module
173+
174+
ext_suffix = distutils.sysconfig.get_config_var("EXT_SUFFIX")
175+
else:
176+
ext_suffix = sysconfig.get_config_var("EXT_SUFFIX")
173177

174178
assert isinstance(ext_suffix, str)
175179
return ext_suffix.rsplit(".", 1)[0].lstrip(".")

src/scikit_build_core/program_search.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import subprocess
77
import sys
88
from pathlib import Path
9-
from typing import TYPE_CHECKING, NamedTuple
9+
from typing import TYPE_CHECKING, Literal, NamedTuple
1010

1111
from packaging.version import InvalidVersion, Version
1212

@@ -18,7 +18,6 @@
1818

1919
from packaging.specifiers import SpecifierSet
2020

21-
from ._compat.typing import Literal
2221

2322
__all__ = [
2423
"Program",

src/scikit_build_core/settings/skbuild_overrides.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import re
66
import sys
77
from pathlib import Path
8-
from typing import TYPE_CHECKING, Any
8+
from typing import TYPE_CHECKING, Any, Literal
99

1010
import packaging.tags
1111
from packaging.specifiers import SpecifierSet
@@ -28,8 +28,6 @@ def __dir__() -> list[str]:
2828
if TYPE_CHECKING:
2929
from collections.abc import Mapping
3030

31-
from .._compat.typing import Literal
32-
3331

3432
def strtobool(value: str) -> bool:
3533
"""

tests/test_setuptools_pep517.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import importlib.metadata
12
import tarfile
23
import textwrap
34
import zipfile
@@ -6,11 +7,10 @@
67
import pytest
78
from packaging.version import Version
89

9-
from scikit_build_core._compat.importlib import metadata
1010
from scikit_build_core.setuptools.build_meta import build_sdist, build_wheel
1111

1212
pytestmark = pytest.mark.setuptools
13-
setuptools_version = Version(metadata.version("setuptools"))
13+
setuptools_version = Version(importlib.metadata.version("setuptools"))
1414

1515

1616
@pytest.mark.usefixtures("package_simple_setuptools_ext")

0 commit comments

Comments
 (0)